Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] displays custom bounds error for right axis when lower bound is above 0 #124037

Merged
merged 2 commits into from
Jan 31, 2022
Merged

[Lens] displays custom bounds error for right axis when lower bound is above 0 #124037

merged 2 commits into from
Jan 31, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jan 28, 2022 •
edited
Loading

Summary

Closes #123115
The fix is really simple. We were checking for the left axis instead of the right and this condition was always false.

Now everything work fine.
image

@stratoula stratoula changed the title [Lens] displays custom bounds error for right axis when lower bound i… [Lens] displays custom bounds error for right axis when lower bound is above 0 Jan 28, 2022
@stratoula stratoula added Feature:Lens release_note:fix v8.1.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 28, 2022
@stratoula stratoula marked this pull request as ready for review January 28, 2022 16:09
@stratoula stratoula requested a review from a team as a code owner January 28, 2022 16:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.0MB 1.0MB +1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dej611
dej611 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stratoula stratoula merged commit 7afae17 into elastic:main Jan 31, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 31, 2022
awahab07 pushed a commit to awahab07/kibana that referenced this pull request Jan 31, 2022
@stratoula @kibanamachine @awahab07
[Lens] displays custom bounds error for right axis when lower bound i…
0804633 
…s above 0 (elastic#124037)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Lower bound warning appears only on the left axis
5 participants
@stratoula @elasticmachine @kibana-ci @dej611 @kibanamachine