Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix anomaly detector jobs list filter delay #124328

Merged
merged 1 commit into from
Feb 2, 2022
Merged

[ML] Fix anomaly detector jobs list filter delay #124328

merged 1 commit into from
Feb 2, 2022

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Feb 2, 2022 •
edited
Loading

Removes the debounce which is no longer needed when typing into the AD jobs list filter bar.
The debounce was in the wrong location, rather than being on user's keypresses, the delay was deeper inside the filtering function which caused problems when the input was wiped.

Our other filter bars do not use a debounce and performance does not seem to be affected by its removal.

Fixes #123210

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience release_note:fix :ml Feature:Anomaly Detection ML anomaly detection auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 v8.2.0 labels Feb 2, 2022
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner February 2, 2022 09:30
@jgowdyelastic jgowdyelastic self-assigned this Feb 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic changed the title [ML] Fix anomaly detector jobs list search delay [ML] Fix anomaly detector jobs list filter delay Feb 2, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB -226.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

peteharverson
peteharverson approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and can no longer reproduce the original issue in #123210. LGTM

darnautov
darnautov approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@jgowdyelastic jgowdyelastic removed the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 2, 2022
@jgowdyelastic jgowdyelastic merged commit fd0e1ae into elastic:main Feb 2, 2022
@jgowdyelastic jgowdyelastic deleted the fix-anomaly-detection-jobs-list-search-delay branch February 2, 2022 11:35
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 4, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124328 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124328 or prevent reminders by adding the backport:skip label.

@jgowdyelastic jgowdyelastic added v7.17.1 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 7, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.2 The branch "8.2" is invalid or doesn't exist
❌ 7.17 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 124328

Questions ?

Please refer to the Backport tool documentation

@jgowdyelastic jgowdyelastic added v8.0.1 and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 7, 2022
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 7, 2022
Closed
@jgowdyelastic
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 7, 2022
@jgowdyelastic
[ML] Fix anomaly detector jobs list search delay (elastic#124328)
f8c94f9 
(cherry picked from commit fd0e1ae)

# Conflicts:
#	x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list_view/jobs_list_view.js
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 7, 2022
Closed
@jgowdyelastic
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 7, 2022
@jgowdyelastic
[ML] Fix anomaly detector jobs list search delay (elastic#124328)
15c1903 
(cherry picked from commit fd0e1ae)

# Conflicts:
#	x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list_view/jobs_list_view.js
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 7, 2022
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Feb 7, 2022
@jgowdyelastic
[ML] Fix anomaly detector jobs list search delay (elastic#124328)
dac60f1 
(cherry picked from commit fd0e1ae)

# Conflicts:
#	x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list_view/jobs_list_view.js
@jgowdyelastic jgowdyelastic mentioned this pull request Feb 7, 2022
Merged
@jgowdyelastic
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.0
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@pheyos pheyos mentioned this pull request Feb 8, 2022
Closed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 8, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

jgowdyelastic added a commit that referenced this pull request Feb 9, 2022
@jgowdyelastic
[ML] Fix anomaly detector jobs list search delay (#124328) (#124846)
2a75614 
(cherry picked from commit fd0e1ae)

# Conflicts:
#	x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list_view/jobs_list_view.js
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 11, 2022
jgowdyelastic added a commit that referenced this pull request Feb 11, 2022
@jgowdyelastic @kibanamachine
[ML] Fix anomaly detector jobs list search delay (#124328) (#124845)
8de9d60 
(cherry picked from commit fd0e1ae)

# Conflicts:
#	x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list_view/jobs_list_view.js

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@pheyos pheyos mentioned this pull request Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.17.1 v8.0.1 v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Job list filtering sometimes fails
6 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @darnautov @peteharverson