[Security Solution] Bugfix for inspect index pattern not aligned with data view index pattern #125007
Conversation
stephmilovic
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
| }); | ||
|
|
||
| test('Close Inspect Modal', () => { |
There was a problem hiding this comment.
Deleted this test because is duplicate of a test in modal.test.tsx
| title, | ||
| }: ModalInspectProps) => { | ||
| if (!isShowing || request == null || response == null) { |
There was a problem hiding this comment.
Moved this check into the inspect/index.tsx where the modal is called from so we don't have to worry about the hooks being called conditionally.
| const response = | ||
| '{"took": 880,"timed_out": false,"_shards": {"total": 26,"successful": 26,"skipped": 0,"failed": 0},"hits": {"max_score": null,"hits": []},"aggregations": {"hosts": {"value": 541},"hosts_histogram": {"buckets": [{"key_as_string": "2019 - 07 - 05T01: 00: 00.000Z", "key": 1562288400000, "doc_count": 1492321, "count": { "value": 105 }}, {"key_as_string": "2019 - 07 - 05T13: 00: 00.000Z", "key": 1562331600000, "doc_count": 2412761, "count": { "value": 453}},{"key_as_string": "2019 - 07 - 06T01: 00: 00.000Z", "key": 1562374800000, "doc_count": 111658, "count": { "value": 15}}],"interval": "12h"}},"status": 200}'; | ||
|
|
||
| describe('Modal Inspect', () => { | ||
| const closeModal = jest.fn(); | ||
|
|
||
| describe('rendering', () => { | ||
| test('when isShowing is positive and request and response are not null', () => { |
There was a problem hiding this comment.
moved this check to inspect/index.tsx so the tests are now in inspect/index.test.tsx
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
… data view index pattern (elastic#125007) (cherry picked from commit bad98b6)
💔 Some backports could not be created
How to fixRe-run the backport manually: Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
Resolves Issue #121377
Some widgets in the security app do not match the sourcerer data view pattern. Add messaging where this happens:
When
logs-*is included in the sourcerer selection, we append an exclude for Elastic cloud logs. Add messaging explaining that:Checklist
Delete any items that are not applicable to this PR.