Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add functional tests for Data Frame Analytics results view content/table behavior #125162

Merged
merged 13 commits into from
Feb 17, 2022
Merged

[ML] Add functional tests for Data Frame Analytics results view content/table behavior #125162

merged 13 commits into from
Feb 17, 2022

Conversation

qn895
Copy link
Member

@qn895 qn895 commented Feb 9, 2022

Summary

Part of #117501. This PR adds functional tests for Data Frame Analytics results view content/table behavior

Checklist

@qn895 qn895 requested a review from a team as a code owner February 9, 2022 21:53
@qn895 qn895 self-assigned this Feb 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@qn895 qn895 added release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Feb 9, 2022
@qn895 qn895 mentioned this pull request Feb 10, 2022
Closed
13 tasks
pheyos
pheyos reviewed Feb 14, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with the common data grid service refactoring! 🎉
Left a few follow-up comments.

x-pack/test/functional/services/transform/wizard.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/common_data_grid.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/common_data_grid.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/common_data_grid.ts Show resolved Hide resolved
x-pack/test/functional/services/ml/common_data_grid.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/common_data_grid.ts Outdated Show resolved Hide resolved
x-pack/test/functional/services/ml/common_data_grid.ts Outdated Show resolved Hide resolved
@qn895 qn895 requested a review from pheyos February 15, 2022 18:37
pheyos
pheyos approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one follow-up suggestion.

x-pack/test/functional/services/ml/common_data_grid.ts Outdated Show resolved Hide resolved
@pheyos
Copy link
Member

pheyos commented Feb 16, 2022

After the data grid service refactoring, I'm checking the stability of DFA and TFM tests in a flaky test runner job ...

@qn895
Copy link
Member Author

qn895 commented Feb 16, 2022 •
edited
Loading

Failed tests seemed unrelated to the PR so I'm running the flaky test suite again ... Some tests failed but unrelated to this PR and are being skipped #125455

@pheyos
Copy link
Member

pheyos commented Feb 17, 2022

@qn895 Seeing that in the last flaky test runner job only the tests failed, that are now skipped and the tests related to this PR's changes all passed, I'd consider this a green light.

@qn895
Copy link
Member Author

qn895 commented Feb 17, 2022

@elasticmachine merge upstream

@qn895 qn895 enabled auto-merge (squash) February 17, 2022 15:23
@qn895 qn895 merged commit a92a9ff into elastic:main Feb 17, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @qn895

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 21, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125162 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125162 or prevent reminders by adding the backport:skip label.

@peteharverson peteharverson added auto-backport Deprecated - use backport:version if exact versions are needed and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 22, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.1 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 125162

Questions ?

Please refer to the Backport tool documentation

@peteharverson peteharverson added backport:skip This commit does not require backporting and removed auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 labels Feb 22, 2022
@peteharverson peteharverson mentioned this pull request Feb 22, 2022
Closed
5 tasks
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@qn895 @kibanamachine @lucasfcosta
[ML] Add functional tests for Data Frame Analytics results view conte…
368e80e 
…nt/table behavior (elastic#125162)

* Add functional tests for DFA results view content/table behavior

* Rename methods/variables, refactor data grid into ml common service

* Refactor to common data grid service

* Move to ml.commonDataGrid service

* Address comments

* Add assertion for switch state

* Fix + 1

* Flaky tests

* Fix assertion texts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@qn895 qn895 deleted the ml-dfa-results-func-tests branch March 29, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@walterra walterra Awaiting requested review from walterra

@peteharverson peteharverson Awaiting requested review from peteharverson

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@qn895 qn895

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qn895 @elasticmachine @pheyos @kibana-ci @kibanamachine @peteharverson