[Fleet] showing agent policy creation error message on UI

[juliaElastic]

Summary

Closes #125904

Showing error message from API if available on agent policy creation error.

To verify:

• Create agent policy with name "Agent policy 1" in Add agent flyout
• Try again to create with the same name
• Expect an error message saying there is already a policy with the same name

[elasticmachine]

Pinging @elastic/fleet (Team:Fleet)

[nchaulet]

@juliaElastic code looks and it work as expected, in most of the place we are using toast notifications for errors, not sure if we should do the same here.

How I see the error existed before my bad no reason to change this.

[nchaulet]

🚀

[hop-dev]

Tested locally, code looks good 👍

[kpollich]

Presenting the ID in the error message like this seems like it might be a bit of unnecessary noise and confusion. We rarely reference agent policies by ID anywhere else in the UI, and in general, they are only displayed in URL's/links. For example, we don't even present the ID in the Agent Policy listing table - only the name.

It is a bit of a challenge when we handle errors like this because the simplest thing to do is just pass the server error on to the UI, but then we are left with the decision to make all server thrown errors presentable in the UI. The other option would be to do something like an error mapping utility that maps server error codes to presentable errors.

However, I think all of this is moot because this error looks like it's coming directly from the SO client, or at least I can't otherwise find the error message in our codebase. With that in mind, I think we can just move on with this error message. 🚀

[juliaElastic]

Presenting the ID in the error message like this seems like it might be a bit of unnecessary noise and confusion. We rarely reference agent policies by ID anywhere else in the UI, and in general, they are only displayed in URL's/links. For example, we don't even present the ID in the Agent Policy listing table - only the name.

It is a bit of a challenge when we handle errors like this because the simplest thing to do is just pass the server error on to the UI, but then we are left with the decision to make all server thrown errors presentable in the UI. The other option would be to do something like an error mapping utility that maps server error codes to presentable errors.

However, I think all of this is moot because this error looks like it's coming directly from the SO client, or at least I can't otherwise find the error message in our codebase. With that in mind, I think we can just move on with this error message. 🚀

@kpollich Yes, I've thought about this and what I could do is map the error message based on http status code. e.g. 409 would be conflict - policy already exists.
For other statuses I could hide that extra message to avoid showing something too technical like the id. (I'm not really sure how to simulate other errors like 400, 401, etc. to check the exact message coming from backend).

@nchaulet to your point, the callout design is coming from UX design doc of the #108456 feature

[juliaElastic]

@kpollich updated to map 409 error to fix the raised issue only

[juliaElastic]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 4f7478d
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
fleet	660.8KB	661.2KB	+325.0B

History

• 💚 Build #25009 succeeded b6b06d0
• 💔 Build #24962 failed 1333a06

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[amolnater-qasource]

Hi @juliaElastic
We have validated this PR with respect to reported issue at #125904 on 8.1 BC-4 Kibana cloud environment.
We have found it working fine now.

• Descriptive error message for creating duplicate policy from Add Agent flyout is there.

Build details:
BUILD: 50428
COMMIT: 015578b

Screenshot:

Thanks