[TSVB] Multi-field group by #126015

alexwizp · 2022-02-18T10:13:26Z

Closes: #125063

Summary

The "group by" terms should allow multiple fields using multi field terms under the hood.

Screen

Screen.Recording.2022-02-28.at.12.31.19.PM.mov

Screen.Recording.2022-02-28.at.12.50.23.PM.mov

Todo list:

update the FieldSelect component to work with multi fields
update panel_model.ts. terms_field and pivot_id should support Array<string | null>
client: Activate new mode for Table -> Group By and Terms -> By
server: Add support for Table -> Group By
server: Add support for Terms -> By backend
update convert_series_to_datatable
update Navigate to Lens
update Tests

alexwizp · 2022-02-25T17:47:53Z

@elasticmachine merge upstream

elasticmachine · 2022-02-28T09:53:09Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

alexwizp · 2022-02-28T09:53:25Z

@elasticmachine merge upstream

miltonhultgren · 2022-02-28T10:11:59Z

x-pack/plugins/infra/server/lib/adapters/metrics/kibana_metrics_adapter.ts

@@ -83,7 +83,7 @@ export class KibanaMetricsAdapter implements InfraMetricsAdapter {
              series: panel.series.map((series) => {
                return {
                  id: series.id,
-                  label: series.label,
+                  label: [series.label].flat()[0],


Is this change intentional?
As far as I can understand this will have no effect?

Yes, this is by design to avoid type errors on your end. When using splitting by one field, everything will continue to work as before

Makes sense, if you're making other changes it would be great if you could include that context in a code comment!

stratoula

Alex thanx a lot for working on this, it loos great!

Can we also remove this question from our TSVB docs?

https://www.elastic.co/guide/en/kibana/current/tsvb.html (it suggests runtime fields but now we can support it natively so no need for this)

I navigate to Lens with two fields but the break down label is misleading

If you re-create it in Lens the label is "Top values of + 1 other". Can we align the behaviors? consider it as a nit though.

Creating filters with clicking on the timeseries chart doesn't work for multi fields terms
It is a bit confusing to understand what this plus button does. Can we add it a bit closer to the terms dropdown?

Can we respect the plural here? (2 others). Lens also does it

flash1293

On using "series aggs", the label seems to run through the multi terms formatting using the caret separator even though it got collapsed:

It should just say "Series agg (sum)"

Otherwise this looks pretty good to me (also saw the points from Stratoulas list) 👍

flash1293 · 2022-03-01T11:41:22Z

src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/table/date_histogram.ts

@@ -24,7 +24,8 @@ export const dateHistogram: TableRequestProcessorsFunction =

    const meta: TableSearchRequestMeta = {
      timeField,
-      index: panel.use_kibana_indexes ? seriesIndex.indexPattern?.id : undefined,


nit: In src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/annotations/query.test.ts and src/plugins/vis_types/timeseries/server/lib/vis_data/request_processors/table/query.test.ts there are a few leftovers of the index property.

@flash1293 these indexes related to filter object. It's not related to that PR

alexwizp · 2022-03-02T12:50:18Z

@elasticmachine merge upstream

alexwizp · 2022-03-02T13:20:42Z

Creating filters with clicking on the timeseries chart doesn't work for multi fields terms

I see that feature is working well for limited cases. Reported issue for that here #126671 .
Not a blocker for that PR

kibana-ci · 2022-03-02T14:15:36Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`visTypeTimeseries`	298	302	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.1MB	1.1MB	+159.0B
`visTypeTimeseries`	462.1KB	470.5KB	+8.4KB
total			+8.6KB

History

💚 Build #26733 succeeded a4c01b1
💚 Build #26472 succeeded b2e49d1
💚 Build #26415 succeeded 18a107f
💚 Build #26393 succeeded 8d46626
💛 Build #26389 was flaky fbde9fa
💔 Build #26385 failed ee763aa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

stratoula

This works great Alex, thank you a lot! Let's fix all the filter events bugs on a separate PR. I am fine with that! LGTM!

* fieldSelect * activate multifield support for table * update table>pivot request_processor * fix some tests * apply some changes * fix JEST * push initial logic for series request_processor * fix some broken cases for Table tab * update convert_series_to_datatable / convert_series_to_vars * add some logic * fix table/terms * do some logic * fix some issues * push some logic * navigation to Lens * fix CI * add excludedFieldFormatsIds param into excludedFieldFormatsIds * fix ci * fix translations * fix some comments * fix series_agg label * update labels in lens Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

alexwizp force-pushed the multi_fields_support branch from 87eb678 to 6fcdbbf Compare February 18, 2022 11:35

fieldSelect

84c871c

alexwizp force-pushed the multi_fields_support branch from 6fcdbbf to 84c871c Compare February 18, 2022 12:27

alexwizp added 8 commits February 18, 2022 15:37

activate multifield support for table

d7e2194

update table>pivot request_processor

6f22c74

fix some tests

22e16e9

apply some changes

c853a20

fix JEST

12eb724

push initial logic for series request_processor

298e640

fix some broken cases for Table tab

7bf679b

update convert_series_to_datatable / convert_series_to_vars

afb0213

alexwizp force-pushed the multi_fields_support branch from 06475a0 to 1dc35d9 Compare February 21, 2022 16:22

add some logic

4d3d47c

alexwizp force-pushed the multi_fields_support branch from 1dc35d9 to 4d3d47c Compare February 21, 2022 20:19

alexwizp added 4 commits February 22, 2022 12:31

fix table/terms

ebe8bec

do some logic

173ede9

fix some issues

b237f56

push some logic

01d905f

alexwizp force-pushed the multi_fields_support branch 3 times, most recently from fecf7f7 to 11c223f Compare February 24, 2022 12:12

navigation to Lens

0c3e618

alexwizp force-pushed the multi_fields_support branch from 11c223f to 0c3e618 Compare February 24, 2022 13:02

alexwizp added 4 commits February 24, 2022 16:02

Merge remote-tracking branch 'upstream/main' into multi_fields_support

5ec9c15

fix CI

7198cd6

add excludedFieldFormatsIds param into excludedFieldFormatsIds

ee763aa

fix ci

fbde9fa

kibanamachine and others added 2 commits February 25, 2022 12:48

Merge branch 'main' into multi_fields_support

8d46626

fix translations

18a107f

alexwizp requested a review from a team as a code owner February 28, 2022 09:52

alexwizp self-assigned this Feb 28, 2022

alexwizp added the v8.2.0 label Feb 28, 2022

alexwizp added Feature:TSVB TSVB (Time Series Visual Builder) release_note:feature Makes this part of the condensed release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 28, 2022

Merge branch 'main' into multi_fields_support

b2e49d1

miltonhultgren reviewed Feb 28, 2022

View reviewed changes

miltonhultgren approved these changes Feb 28, 2022

View reviewed changes

stratoula reviewed Feb 28, 2022

View reviewed changes

fix some comments

a4c01b1

alexwizp added the backport:skip This commit does not require backporting label Mar 1, 2022

flash1293 reviewed Mar 1, 2022

View reviewed changes

alexwizp added 2 commits March 2, 2022 14:21

fix series_agg label

660093d

update labels in lens

b997a1f

Merge branch 'main' into multi_fields_support

7d60c07

alexwizp requested a review from stratoula March 2, 2022 14:39

stratoula approved these changes Mar 3, 2022

View reviewed changes

alexwizp merged commit efcdbb6 into elastic:main Mar 3, 2022

flash1293 mentioned this pull request Mar 17, 2022

Kubernetes overview dashboard: metric visualization displays incorrect data elastic/integrations#2159

Closed

ChrsMark mentioned this pull request Mar 18, 2022

Improve k8s dashboard elastic/beats#30913

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TSVB] Multi-field group by #126015

[TSVB] Multi-field group by #126015

alexwizp commented Feb 18, 2022 •

edited

Loading

alexwizp commented Feb 25, 2022

elasticmachine commented Feb 28, 2022

alexwizp commented Feb 28, 2022

miltonhultgren Feb 28, 2022

alexwizp Feb 28, 2022

miltonhultgren Feb 28, 2022

stratoula left a comment •

edited by alexwizp

Loading

flash1293 left a comment

flash1293 Mar 1, 2022

alexwizp Mar 2, 2022

alexwizp commented Mar 2, 2022

alexwizp commented Mar 2, 2022

kibana-ci commented Mar 2, 2022

stratoula left a comment

[TSVB] Multi-field group by #126015

[TSVB] Multi-field group by #126015

Conversation

alexwizp commented Feb 18, 2022 • edited Loading

Summary

Screen

Todo list:

alexwizp commented Feb 25, 2022

elasticmachine commented Feb 28, 2022

alexwizp commented Feb 28, 2022

miltonhultgren Feb 28, 2022

Choose a reason for hiding this comment

alexwizp Feb 28, 2022

Choose a reason for hiding this comment

miltonhultgren Feb 28, 2022

Choose a reason for hiding this comment

stratoula left a comment • edited by alexwizp Loading

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

flash1293 Mar 1, 2022

Choose a reason for hiding this comment

alexwizp Mar 2, 2022

Choose a reason for hiding this comment

alexwizp commented Mar 2, 2022

alexwizp commented Mar 2, 2022

kibana-ci commented Mar 2, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

stratoula left a comment

Choose a reason for hiding this comment

alexwizp commented Feb 18, 2022 •

edited

Loading

stratoula left a comment •

edited by alexwizp

Loading