Toast Notification should handle connection failed #12609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickypg
added
bug
tsullivan
reviewed
Jun 30, 2017
| rtn += 'Error ' + err.status + ' ' + err.statusText + ': ' + err.data.message; | ||
| if (err.status === -1) { | ||
| // status = -1 indicates that the request was failed to reach the server | ||
| rtn += 'Connection failed! Is Kibana running?'; |
There was a problem hiding this comment.
This message feels a little accusatory towards the user. How about something. Like:
A request to the Kibana server has failed to connect. Please check if the Kibana server is running and that your browser has a working connection to the Internet.
There was a problem hiding this comment.
I like it, but I'm going to drop the to the Internet part at the end to avoid confusing users running it locally / internally on an intranet.
There was a problem hiding this comment.
Ended up with:
An HTTP request has failed to connect. Please check if the Kibana server is running and that your browser has a working connection, or contact your system administrator.
|
please test this |
|
5.x/5.6: 5e5ea2d |
jimgoodwin
added
release_note:fix
Team:Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this happen while using the
Notifierto send a failure to it from Angular that was unable to reach the server. This allows theNotifierto display a helpful error rather than triggering one itself.Note:
err.datais explicitlynullin this case, so ithasit, but it is not useful, which is why this triggers a browser exception.