[Uptime] fix synthetics recorder file upload #127614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiqueclarke
added
v8.2.0
release_note:fix
auto-backport
|
Pinging @elastic/uptime (Team:uptime) |
dominiqueclarke
commented
Mar 31, 2022
| @@ -38,7 +38,7 @@ export function Uploader({ onUpload }: Props) { | |||
| onUpload({ scriptText: '', fileName: '' }); | |||
| return; | |||
| } | |||
| if (files.length && files[0].type !== 'text/javascript') { | |||
| if (files.length && !files[0].type.includes('javascript')) { | |||
There was a problem hiding this comment.
MIght need to have regex that includes javascript and ecmascript.
dominiqueclarke
changed the title
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
shahzad31
approved these changes
Apr 7, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Apr 7, 2022
Co-authored-by: shahzad31 <shahzad.muhammad@elastic.co> (cherry picked from commit 347acc9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 7, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #127515
Accepts
text/javascript,application/javascriptandapplication/x-javascriptmime types for the Script Recorder upload.Testing
Testing should be done in Chrome, Firefox and Safari.