Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix mosaic color syncing #127707

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #125831

Screenshot 2022-03-15 at 09 56 35

In case of sync colors being enabled, the second layer should be used to determine the color, not the first one (which is different than treemap behavior). The old code was handling both chart types the same way, this fix makes sure the right layer is used.

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting v8.2.0 labels Mar 15, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionPartitionVis 47.2KB 47.3KB +27.0B
Unknown metric groups

References to deprecated APIs

id before after diff
expressionPartitionVis 6 8 +2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review March 15, 2022 11:16
@flash1293 flash1293 requested a review from a team as a code owner March 15, 2022 11:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, mosaic coloring now works as expected. I also did some tests with treemap and mosaic. LGTM

@flash1293 flash1293 merged commit 737ec83 into elastic:main Mar 15, 2022
maksimkovalev pushed a commit to maksimkovalev/kibana that referenced this pull request Mar 18, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Mosaic visualization has incorrect colors when "Sync color palette across panels" is enabled
4 participants