Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix functional tests #127979

Merged
merged 2 commits into from
Mar 18, 2022
Merged

fix functional tests #127979

merged 2 commits into from
Mar 18, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #107854

By retrying runtime field creation

Fixes #102332

By waiting for the vis to render before asserting it

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens v8.2.0 v8.1.1 v8.0.2 v7.17.2 auto-backport Deprecated: Automatically backport this PR after it's merged labels Mar 17, 2022
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review March 17, 2022 18:01
@flash1293 flash1293 requested a review from a team as a code owner March 17, 2022 18:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, code review only 🤞

@stratoula stratoula added the release_note:skip Skip the PR/issue when compiling release notes label Mar 18, 2022
@flash1293 flash1293 merged commit 1c7f805 into elastic:main Mar 18, 2022
kibanamachine pushed a commit that referenced this pull request Mar 18, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 1c7f805)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.1
7.17 Backport failed because of merge conflicts
8.0 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 127979

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

flash1293 added a commit to flash1293/kibana that referenced this pull request Mar 18, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 1c7f805)

# Conflicts:
#	x-pack/test/functional/apps/lens/runtime_fields.ts
flash1293 added a commit to flash1293/kibana that referenced this pull request Mar 18, 2022
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 1c7f805)

# Conflicts:
#	x-pack/test/functional/apps/lens/runtime_fields.ts
flash1293 added a commit that referenced this pull request Mar 18, 2022
* fix functional tests (#127979)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 1c7f805)

# Conflicts:
#	x-pack/test/functional/apps/lens/runtime_fields.ts

* Update add_to_dashboard.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 22, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@flash1293 flash1293 removed the v8.0.2 label Mar 22, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 23, 2022
kibanamachine added a commit that referenced this pull request Mar 23, 2022
* fix functional tests (#127979)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 1c7f805)

* Update add_to_dashboard.ts

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.17.2 v8.1.1 v8.2.0
Projects
None yet
5 participants