-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Cross compile docker images #128272
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This reverts commit 621780e.
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the build on a remote-dev instance, loaded the arm64 build and the aarch64 docker image to a graviton instance and they both seemed to work great. LGTM
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
@spalger @jbudz the change in this PR force to use buildx always even though you do not want to cross compile Docker images other than x86_64
cause the following error
|
@kuisathaverat I have a fix up at #128560. |
On our end, we have included buildx in our Kibana Docker image builder on Friday |
* [build] Cross compile docker images * typo * debug * Revert "[build] Cross compile docker images" This reverts commit 621780e. * revert * support docker-cross-compile flag * fix types/tests * fix more tests * download cloud dependencies based on cross compile flag * fix array * fix more tests
* [7.17] [build] Cross compile docker images (#128272) * [build] Cross compile docker images * typo * debug * Revert "[build] Cross compile docker images" This reverts commit 621780e. * revert * support docker-cross-compile flag * fix types/tests * fix more tests * download cloud dependencies based on cross compile flag * fix array * fix more tests * rm extra file
This adds a new flag to
scripts/build
,--docker-cross-compile
. This flag will attempt to create docker images for both amd64 and arm64 using docker's buildx environment - https://docs.docker.com/buildx/working-with-bux/.The primary use case we are trying to support is building ARM64 images from AMD64. We use GCP on CI, and GCP does not support ARM architectures yet.
By default this is off to maintain backwards compatibility with our current build workflow. QEMU needs to be setup on the local environment to support cross compilation, which is outside the scope of our build scripts.
TODO
Testing