Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Only use buildx if cross compiling #128560

Merged
merged 6 commits into from
Apr 7, 2022
Merged

[build] Only use buildx if cross compiling #128560

merged 6 commits into from
Apr 7, 2022

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Mar 25, 2022

#128272 wrongly assumed that docker buildx is available for all docker installs. This reverts back to the old behavior of using docker build when not cross compiling.

@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.2.0 ci:build-os-packages labels Mar 25, 2022
@jbudz jbudz mentioned this pull request Mar 25, 2022
Merged
1 task
@jbudz jbudz marked this pull request as ready for review March 28, 2022 13:25
@jbudz jbudz requested a review from a team as a code owner March 28, 2022 13:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz added v8.3.0 v7.17.3 auto-backport Deprecated: Automatically backport this PR after it's merged and removed backport:skip This commit does not require backporting labels Apr 4, 2022
mistic
mistic approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rockdaboot
rockdaboot approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Succeeds for me (before: build failure) and LGTM.

@jbudz jbudz enabled auto-merge (squash) April 7, 2022 16:11
@jbudz jbudz merged commit bcdb0b2 into elastic:main Apr 7, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request Apr 7, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 7, 2022
@jbudz
[build] Only use buildx if cross compiling (#128560)
1896778 
* [build] Only use buildx if cross compiling

* reuse variable

* fix conditional

(cherry picked from commit bcdb0b2)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
✅ 8.2
❌ 7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- [build] Cross compile docker images (#128272)
- [ci] Verify docker contexts (#122897)

Manual backport

To create the backport manually run:

node scripts/backport --pr 128560

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jbudz added a commit to jbudz/kibana that referenced this pull request Apr 7, 2022
@jbudz
[7.17] [build] Only use buildx if cross compiling (elastic#128560)
cb89e09 
* [build] Only use buildx if cross compiling

* reuse variable

* fix conditional
mitodrummer pushed a commit to mitodrummer/kibana that referenced this pull request Apr 7, 2022
@jbudz
[build] Only use buildx if cross compiling (elastic#128560)
0624bdf 
* [build] Only use buildx if cross compiling

* reuse variable

* fix conditional

fix jump to nested entity_id. also defaulting verbose mode to OFF
kibanamachine added a commit that referenced this pull request Apr 7, 2022
@kibanamachine @jbudz
[build] Only use buildx if cross compiling (#128560) (#129778)
9e7b53e 
* [build] Only use buildx if cross compiling

* reuse variable

* fix conditional

(cherry picked from commit bcdb0b2)

Co-authored-by: Jonathan Budzenski <jon@elastic.co>
jbudz added a commit that referenced this pull request Apr 7, 2022
@jbudz
[7.17] [build] Only use buildx if cross compiling (#128560) (#129781)
fc6ea53 
* [build] Only use buildx if cross compiling

* reuse variable

* fix conditional
@jbudz
Copy link
Member Author

jbudz commented Apr 7, 2022

7.17: fc6ea53

@kibanamachine kibanamachine mentioned this pull request Jan 3, 2024
Merged
@kibanamachine kibanamachine mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders approved these changes

@rockdaboot rockdaboot rockdaboot approved these changes

@mistic mistic mistic approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged backported ci:build-os-packages release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.3 v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jbudz @elasticmachine @kibana-ci @kibanamachine @brianseeders @rockdaboot @mistic