Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query queue should be cleared on failure #12942

Merged
merged 1 commit into from
Jul 19, 2017
Merged

query queue should be cleared on failure #12942

merged 1 commit into from
Jul 19, 2017

Conversation

ppisljar
Copy link
Member

closes #12940

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0 labels Jul 18, 2017
@ppisljar ppisljar self-assigned this Jul 18, 2017
thomasneirynck
thomasneirynck approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but without first two commits!

src/core_plugins/markdown_vis/public/markdown_vis.html Outdated
@@ -1,3 +1,3 @@
<div ng-controller="KbnMarkdownVisController" class="markdown-vis">
<div ng-bind-html="html" class="markdown-body"></div>
<div ng-bind-html="html" class="markdown-body" ng-style="{'font-size': vis.params.fontSize + 'pt'}" ></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably want to strip the first two commits from this PR ;)

@ppisljar
Copy link
Member Author

jenkins, test this

@ppisljar ppisljar merged commit 8f03823 into elastic:master Jul 19, 2017
@ppisljar ppisljar deleted the fix/failedQuery branch July 19, 2017 06:26
spalger pushed a commit to tylersmalley/kibana that referenced this pull request Jul 19, 2017
@ppisljar @spalger
cancel queries on fail (elastic#12942)
5202595
@ppisljar ppisljar restored the fix/failedQuery branch September 26, 2018 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@lukasolson lukasolson Awaiting requested review from lukasolson

Assignees

@ppisljar ppisljar

Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix review v6.0.0-rc1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

visualize fatal error on query syntax error
3 participants
@ppisljar @thomasneirynck @jimgoodwin