Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Explicitly Hide Panel Titles Migration #129540

Merged

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Apr 5, 2022

Summary

Fixes #129386
Closes #122878 as this is the third and final part of the fix for that.

This PR adds a migration to dashboard for version 7.10 which finds all panels saved with a blank string panel title and turns on the hidePanelTItles setting for them.

To test locally, you can import the following NDJSON from 7.9.3 which has 3 hidden titles and one shown title.

{"attributes":{"description":"","expression":"kibana\n| kibana_context  query=\"{\\\"query\\\":\\\"\\\",\\\"language\\\":\\\"kuery\\\"}\" filters=\"[]\"\n| lens_merge_tables layerIds=\"ec6850f7-7167-4972-b969-c74e2819610b\" \n  tables={esaggs index=\"d3d7af60-4c81-11e8-b3d7-01146121b73d\" metricsAtAllLevels=true partialRows=true includeFormatHints=true  aggConfigs=\"[{\\\"id\\\":\\\"547c2500-a8dd-4253-952b-1e3bbba7fef6\\\",\\\"enabled\\\":true,\\\"type\\\":\\\"terms\\\",\\\"schema\\\":\\\"segment\\\",\\\"params\\\":{\\\"field\\\":\\\"Carrier\\\",\\\"orderBy\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\",\\\"order\\\":\\\"desc\\\",\\\"size\\\":5,\\\"otherBucket\\\":false,\\\"otherBucketLabel\\\":\\\"Other\\\",\\\"missingBucket\\\":false,\\\"missingBucketLabel\\\":\\\"Missing\\\"}},{\\\"id\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\",\\\"enabled\\\":true,\\\"type\\\":\\\"count\\\",\\\"schema\\\":\\\"metric\\\",\\\"params\\\":{}}]\" | lens_rename_columns idMap=\"{\\\"col-0-547c2500-a8dd-4253-952b-1e3bbba7fef6\\\":{\\\"label\\\":\\\"Top values of Carrier\\\",\\\"dataType\\\":\\\"string\\\",\\\"operationType\\\":\\\"terms\\\",\\\"scale\\\":\\\"ordinal\\\",\\\"sourceField\\\":\\\"Carrier\\\",\\\"isBucketed\\\":true,\\\"params\\\":{\\\"size\\\":5,\\\"orderBy\\\":{\\\"type\\\":\\\"column\\\",\\\"columnId\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\"},\\\"orderDirection\\\":\\\"desc\\\"},\\\"id\\\":\\\"547c2500-a8dd-4253-952b-1e3bbba7fef6\\\"},\\\"col-1-3d0d7678-cebd-4595-bb46-07861e01b6cc\\\":{\\\"label\\\":\\\"Count of records\\\",\\\"dataType\\\":\\\"number\\\",\\\"operationType\\\":\\\"count\\\",\\\"isBucketed\\\":false,\\\"scale\\\":\\\"ratio\\\",\\\"sourceField\\\":\\\"Records\\\",\\\"id\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\"}}\"}\n| lens_xy_chart xTitle=\"Top values of Carrier\" yTitle=\"Count of records\" legend={lens_xy_legendConfig isVisible=true position=\"right\"} fittingFunction=\"None\" \n  layers={lens_xy_layer layerId=\"ec6850f7-7167-4972-b969-c74e2819610b\" hide=false xAccessor=\"547c2500-a8dd-4253-952b-1e3bbba7fef6\" yScaleType=\"linear\" xScaleType=\"ordinal\" isHistogram=false   seriesType=\"bar_stacked\" accessors=\"3d0d7678-cebd-4595-bb46-07861e01b6cc\" columnToLabel=\"{\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\":\\\"Count of records\\\"}\"}","state":{"datasourceMetaData":{"filterableIndexPatterns":[{"id":"d3d7af60-4c81-11e8-b3d7-01146121b73d","title":"kibana_sample_data_flights"}]},"datasourceStates":{"indexpattern":{"currentIndexPatternId":"d3d7af60-4c81-11e8-b3d7-01146121b73d","layers":{"ec6850f7-7167-4972-b969-c74e2819610b":{"columnOrder":["547c2500-a8dd-4253-952b-1e3bbba7fef6","3d0d7678-cebd-4595-bb46-07861e01b6cc"],"columns":{"3d0d7678-cebd-4595-bb46-07861e01b6cc":{"dataType":"number","isBucketed":false,"label":"Count of records","operationType":"count","scale":"ratio","sourceField":"Records"},"547c2500-a8dd-4253-952b-1e3bbba7fef6":{"dataType":"string","isBucketed":true,"label":"Top values of Carrier","operationType":"terms","params":{"orderBy":{"columnId":"3d0d7678-cebd-4595-bb46-07861e01b6cc","type":"column"},"orderDirection":"desc","size":5},"scale":"ordinal","sourceField":"Carrier"}},"indexPatternId":"d3d7af60-4c81-11e8-b3d7-01146121b73d"}}}},"filters":[],"query":{"language":"kuery","query":""},"visualization":{"fittingFunction":"None","layers":[{"accessors":["3d0d7678-cebd-4595-bb46-07861e01b6cc"],"layerId":"ec6850f7-7167-4972-b969-c74e2819610b","position":"top","seriesType":"bar_stacked","showGridlines":false,"xAccessor":"547c2500-a8dd-4253-952b-1e3bbba7fef6"}],"legend":{"isVisible":true,"position":"right"},"preferredSeriesType":"bar_stacked"}},"title":"Panel with Hidden Title 1","visualizationType":"lnsXY"},"id":"46142a00-b1e0-11ec-815f-6160134e7be5","migrationVersion":{"lens":"7.8.0"},"references":[],"type":"lens","updated_at":"2022-04-01T17:22:55.325Z","version":"WzcxLDFd"}
{"attributes":{"description":"","expression":"kibana\n| kibana_context  query=\"{\\\"query\\\":\\\"\\\",\\\"language\\\":\\\"kuery\\\"}\" filters=\"[]\"\n| lens_merge_tables layerIds=\"ec6850f7-7167-4972-b969-c74e2819610b\" \n  tables={esaggs index=\"d3d7af60-4c81-11e8-b3d7-01146121b73d\" metricsAtAllLevels=true partialRows=true includeFormatHints=true  aggConfigs=\"[{\\\"id\\\":\\\"547c2500-a8dd-4253-952b-1e3bbba7fef6\\\",\\\"enabled\\\":true,\\\"type\\\":\\\"terms\\\",\\\"schema\\\":\\\"segment\\\",\\\"params\\\":{\\\"field\\\":\\\"Carrier\\\",\\\"orderBy\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\",\\\"order\\\":\\\"desc\\\",\\\"size\\\":5,\\\"otherBucket\\\":false,\\\"otherBucketLabel\\\":\\\"Other\\\",\\\"missingBucket\\\":false,\\\"missingBucketLabel\\\":\\\"Missing\\\"}},{\\\"id\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\",\\\"enabled\\\":true,\\\"type\\\":\\\"count\\\",\\\"schema\\\":\\\"metric\\\",\\\"params\\\":{}}]\" | lens_rename_columns idMap=\"{\\\"col-0-547c2500-a8dd-4253-952b-1e3bbba7fef6\\\":{\\\"label\\\":\\\"Top values of Carrier\\\",\\\"dataType\\\":\\\"string\\\",\\\"operationType\\\":\\\"terms\\\",\\\"scale\\\":\\\"ordinal\\\",\\\"sourceField\\\":\\\"Carrier\\\",\\\"isBucketed\\\":true,\\\"params\\\":{\\\"size\\\":5,\\\"orderBy\\\":{\\\"type\\\":\\\"column\\\",\\\"columnId\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\"},\\\"orderDirection\\\":\\\"desc\\\"},\\\"id\\\":\\\"547c2500-a8dd-4253-952b-1e3bbba7fef6\\\"},\\\"col-1-3d0d7678-cebd-4595-bb46-07861e01b6cc\\\":{\\\"label\\\":\\\"Count of records\\\",\\\"dataType\\\":\\\"number\\\",\\\"operationType\\\":\\\"count\\\",\\\"isBucketed\\\":false,\\\"scale\\\":\\\"ratio\\\",\\\"sourceField\\\":\\\"Records\\\",\\\"id\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\"}}\"}\n| lens_xy_chart xTitle=\"Top values of Carrier\" yTitle=\"Count of records\" legend={lens_xy_legendConfig isVisible=true position=\"right\"} fittingFunction=\"None\" \n  layers={lens_xy_layer layerId=\"ec6850f7-7167-4972-b969-c74e2819610b\" hide=false xAccessor=\"547c2500-a8dd-4253-952b-1e3bbba7fef6\" yScaleType=\"linear\" xScaleType=\"ordinal\" isHistogram=false   seriesType=\"bar_stacked\" accessors=\"3d0d7678-cebd-4595-bb46-07861e01b6cc\" columnToLabel=\"{\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\":\\\"Count of records\\\"}\"}","state":{"datasourceMetaData":{"filterableIndexPatterns":[{"id":"d3d7af60-4c81-11e8-b3d7-01146121b73d","title":"kibana_sample_data_flights"}]},"datasourceStates":{"indexpattern":{"currentIndexPatternId":"d3d7af60-4c81-11e8-b3d7-01146121b73d","layers":{"ec6850f7-7167-4972-b969-c74e2819610b":{"columnOrder":["547c2500-a8dd-4253-952b-1e3bbba7fef6","3d0d7678-cebd-4595-bb46-07861e01b6cc"],"columns":{"3d0d7678-cebd-4595-bb46-07861e01b6cc":{"dataType":"number","isBucketed":false,"label":"Count of records","operationType":"count","scale":"ratio","sourceField":"Records"},"547c2500-a8dd-4253-952b-1e3bbba7fef6":{"dataType":"string","isBucketed":true,"label":"Top values of Carrier","operationType":"terms","params":{"orderBy":{"columnId":"3d0d7678-cebd-4595-bb46-07861e01b6cc","type":"column"},"orderDirection":"desc","size":5},"scale":"ordinal","sourceField":"Carrier"}},"indexPatternId":"d3d7af60-4c81-11e8-b3d7-01146121b73d"}}}},"filters":[],"query":{"language":"kuery","query":""},"visualization":{"fittingFunction":"None","layers":[{"accessors":["3d0d7678-cebd-4595-bb46-07861e01b6cc"],"layerId":"ec6850f7-7167-4972-b969-c74e2819610b","position":"top","seriesType":"bar_stacked","showGridlines":false,"xAccessor":"547c2500-a8dd-4253-952b-1e3bbba7fef6"}],"legend":{"isVisible":true,"position":"right"},"preferredSeriesType":"bar_stacked"}},"title":"Panel with hidden title 2","visualizationType":"lnsXY"},"id":"489c0d60-b1e0-11ec-815f-6160134e7be5","migrationVersion":{"lens":"7.8.0"},"references":[],"type":"lens","updated_at":"2022-04-01T17:23:09.535Z","version":"WzgyLDFd"}
{"attributes":{"description":"","expression":"kibana\n| kibana_context  query=\"{\\\"query\\\":\\\"\\\",\\\"language\\\":\\\"kuery\\\"}\" filters=\"[]\"\n| lens_merge_tables layerIds=\"ec6850f7-7167-4972-b969-c74e2819610b\" \n  tables={esaggs index=\"d3d7af60-4c81-11e8-b3d7-01146121b73d\" metricsAtAllLevels=true partialRows=true includeFormatHints=true  aggConfigs=\"[{\\\"id\\\":\\\"547c2500-a8dd-4253-952b-1e3bbba7fef6\\\",\\\"enabled\\\":true,\\\"type\\\":\\\"terms\\\",\\\"schema\\\":\\\"segment\\\",\\\"params\\\":{\\\"field\\\":\\\"Carrier\\\",\\\"orderBy\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\",\\\"order\\\":\\\"desc\\\",\\\"size\\\":5,\\\"otherBucket\\\":false,\\\"otherBucketLabel\\\":\\\"Other\\\",\\\"missingBucket\\\":false,\\\"missingBucketLabel\\\":\\\"Missing\\\"}},{\\\"id\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\",\\\"enabled\\\":true,\\\"type\\\":\\\"count\\\",\\\"schema\\\":\\\"metric\\\",\\\"params\\\":{}}]\" | lens_rename_columns idMap=\"{\\\"col-0-547c2500-a8dd-4253-952b-1e3bbba7fef6\\\":{\\\"label\\\":\\\"Top values of Carrier\\\",\\\"dataType\\\":\\\"string\\\",\\\"operationType\\\":\\\"terms\\\",\\\"scale\\\":\\\"ordinal\\\",\\\"sourceField\\\":\\\"Carrier\\\",\\\"isBucketed\\\":true,\\\"params\\\":{\\\"size\\\":5,\\\"orderBy\\\":{\\\"type\\\":\\\"column\\\",\\\"columnId\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\"},\\\"orderDirection\\\":\\\"desc\\\"},\\\"id\\\":\\\"547c2500-a8dd-4253-952b-1e3bbba7fef6\\\"},\\\"col-1-3d0d7678-cebd-4595-bb46-07861e01b6cc\\\":{\\\"label\\\":\\\"Count of records\\\",\\\"dataType\\\":\\\"number\\\",\\\"operationType\\\":\\\"count\\\",\\\"isBucketed\\\":false,\\\"scale\\\":\\\"ratio\\\",\\\"sourceField\\\":\\\"Records\\\",\\\"id\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\"}}\"}\n| lens_xy_chart xTitle=\"Top values of Carrier\" yTitle=\"Count of records\" legend={lens_xy_legendConfig isVisible=true position=\"right\"} fittingFunction=\"None\" \n  layers={lens_xy_layer layerId=\"ec6850f7-7167-4972-b969-c74e2819610b\" hide=false xAccessor=\"547c2500-a8dd-4253-952b-1e3bbba7fef6\" yScaleType=\"linear\" xScaleType=\"ordinal\" isHistogram=false   seriesType=\"bar_stacked\" accessors=\"3d0d7678-cebd-4595-bb46-07861e01b6cc\" columnToLabel=\"{\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\":\\\"Count of records\\\"}\"}","state":{"datasourceMetaData":{"filterableIndexPatterns":[{"id":"d3d7af60-4c81-11e8-b3d7-01146121b73d","title":"kibana_sample_data_flights"}]},"datasourceStates":{"indexpattern":{"currentIndexPatternId":"d3d7af60-4c81-11e8-b3d7-01146121b73d","layers":{"ec6850f7-7167-4972-b969-c74e2819610b":{"columnOrder":["547c2500-a8dd-4253-952b-1e3bbba7fef6","3d0d7678-cebd-4595-bb46-07861e01b6cc"],"columns":{"3d0d7678-cebd-4595-bb46-07861e01b6cc":{"dataType":"number","isBucketed":false,"label":"Count of records","operationType":"count","scale":"ratio","sourceField":"Records"},"547c2500-a8dd-4253-952b-1e3bbba7fef6":{"dataType":"string","isBucketed":true,"label":"Top values of Carrier","operationType":"terms","params":{"orderBy":{"columnId":"3d0d7678-cebd-4595-bb46-07861e01b6cc","type":"column"},"orderDirection":"desc","size":5},"scale":"ordinal","sourceField":"Carrier"}},"indexPatternId":"d3d7af60-4c81-11e8-b3d7-01146121b73d"}}}},"filters":[],"query":{"language":"kuery","query":""},"visualization":{"fittingFunction":"None","layers":[{"accessors":["3d0d7678-cebd-4595-bb46-07861e01b6cc"],"layerId":"ec6850f7-7167-4972-b969-c74e2819610b","position":"top","seriesType":"bar_stacked","showGridlines":false,"xAccessor":"547c2500-a8dd-4253-952b-1e3bbba7fef6"}],"legend":{"isVisible":true,"position":"right"},"preferredSeriesType":"bar_stacked"}},"title":"Panel with hidden title 3","visualizationType":"lnsXY"},"id":"4a5ca920-b1e0-11ec-815f-6160134e7be5","migrationVersion":{"lens":"7.8.0"},"references":[],"type":"lens","updated_at":"2022-04-01T17:23:23.875Z","version":"Wzk0LDFd"}
{"attributes":{"description":"","expression":"kibana\n| kibana_context  query=\"{\\\"query\\\":\\\"\\\",\\\"language\\\":\\\"kuery\\\"}\" filters=\"[]\"\n| lens_merge_tables layerIds=\"ec6850f7-7167-4972-b969-c74e2819610b\" \n  tables={esaggs index=\"d3d7af60-4c81-11e8-b3d7-01146121b73d\" metricsAtAllLevels=true partialRows=true includeFormatHints=true  aggConfigs=\"[{\\\"id\\\":\\\"547c2500-a8dd-4253-952b-1e3bbba7fef6\\\",\\\"enabled\\\":true,\\\"type\\\":\\\"terms\\\",\\\"schema\\\":\\\"segment\\\",\\\"params\\\":{\\\"field\\\":\\\"Carrier\\\",\\\"orderBy\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\",\\\"order\\\":\\\"desc\\\",\\\"size\\\":5,\\\"otherBucket\\\":false,\\\"otherBucketLabel\\\":\\\"Other\\\",\\\"missingBucket\\\":false,\\\"missingBucketLabel\\\":\\\"Missing\\\"}},{\\\"id\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\",\\\"enabled\\\":true,\\\"type\\\":\\\"count\\\",\\\"schema\\\":\\\"metric\\\",\\\"params\\\":{}}]\" | lens_rename_columns idMap=\"{\\\"col-0-547c2500-a8dd-4253-952b-1e3bbba7fef6\\\":{\\\"label\\\":\\\"Top values of Carrier\\\",\\\"dataType\\\":\\\"string\\\",\\\"operationType\\\":\\\"terms\\\",\\\"scale\\\":\\\"ordinal\\\",\\\"sourceField\\\":\\\"Carrier\\\",\\\"isBucketed\\\":true,\\\"params\\\":{\\\"size\\\":5,\\\"orderBy\\\":{\\\"type\\\":\\\"column\\\",\\\"columnId\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\"},\\\"orderDirection\\\":\\\"desc\\\"},\\\"id\\\":\\\"547c2500-a8dd-4253-952b-1e3bbba7fef6\\\"},\\\"col-1-3d0d7678-cebd-4595-bb46-07861e01b6cc\\\":{\\\"label\\\":\\\"Count of records\\\",\\\"dataType\\\":\\\"number\\\",\\\"operationType\\\":\\\"count\\\",\\\"isBucketed\\\":false,\\\"scale\\\":\\\"ratio\\\",\\\"sourceField\\\":\\\"Records\\\",\\\"id\\\":\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\"}}\"}\n| lens_xy_chart xTitle=\"Top values of Carrier\" yTitle=\"Count of records\" legend={lens_xy_legendConfig isVisible=true position=\"right\"} fittingFunction=\"None\" \n  layers={lens_xy_layer layerId=\"ec6850f7-7167-4972-b969-c74e2819610b\" hide=false xAccessor=\"547c2500-a8dd-4253-952b-1e3bbba7fef6\" yScaleType=\"linear\" xScaleType=\"ordinal\" isHistogram=false   seriesType=\"bar_stacked\" accessors=\"3d0d7678-cebd-4595-bb46-07861e01b6cc\" columnToLabel=\"{\\\"3d0d7678-cebd-4595-bb46-07861e01b6cc\\\":\\\"Count of records\\\"}\"}","state":{"datasourceMetaData":{"filterableIndexPatterns":[{"id":"d3d7af60-4c81-11e8-b3d7-01146121b73d","title":"kibana_sample_data_flights"}]},"datasourceStates":{"indexpattern":{"currentIndexPatternId":"d3d7af60-4c81-11e8-b3d7-01146121b73d","layers":{"ec6850f7-7167-4972-b969-c74e2819610b":{"columnOrder":["547c2500-a8dd-4253-952b-1e3bbba7fef6","3d0d7678-cebd-4595-bb46-07861e01b6cc"],"columns":{"3d0d7678-cebd-4595-bb46-07861e01b6cc":{"dataType":"number","isBucketed":false,"label":"Count of records","operationType":"count","scale":"ratio","sourceField":"Records"},"547c2500-a8dd-4253-952b-1e3bbba7fef6":{"dataType":"string","isBucketed":true,"label":"Top values of Carrier","operationType":"terms","params":{"orderBy":{"columnId":"3d0d7678-cebd-4595-bb46-07861e01b6cc","type":"column"},"orderDirection":"desc","size":5},"scale":"ordinal","sourceField":"Carrier"}},"indexPatternId":"d3d7af60-4c81-11e8-b3d7-01146121b73d"}}}},"filters":[],"query":{"language":"kuery","query":""},"visualization":{"fittingFunction":"None","layers":[{"accessors":["3d0d7678-cebd-4595-bb46-07861e01b6cc"],"layerId":"ec6850f7-7167-4972-b969-c74e2819610b","position":"top","seriesType":"bar_stacked","showGridlines":false,"xAccessor":"547c2500-a8dd-4253-952b-1e3bbba7fef6"}],"legend":{"isVisible":true,"position":"right"},"preferredSeriesType":"bar_stacked"}},"title":"Panel with Shown Title","visualizationType":"lnsXY"},"id":"4c349d70-b1e0-11ec-815f-6160134e7be5","migrationVersion":{"lens":"7.8.0"},"references":[],"type":"lens","updated_at":"2022-04-01T17:24:28.875Z","version":"WzEyMiwxXQ=="}
{"attributes":{"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"language\":\"kuery\",\"query\":\"\"},\"filter\":[]}"},"optionsJSON":"{\"hidePanelTitles\":false,\"useMargins\":true}","panelsJSON":"[{\"version\":\"7.9.3\",\"gridData\":{\"h\":15,\"i\":\"ad30af17-3897-4988-8dd9-1d4ccec60324\",\"w\":24,\"x\":0,\"y\":0},\"panelIndex\":\"ad30af17-3897-4988-8dd9-1d4ccec60324\",\"embeddableConfig\":{\"title\":\"\"},\"panelRefName\":\"panel_0\"},{\"version\":\"7.9.3\",\"gridData\":{\"h\":15,\"i\":\"1132db5f-6fe9-4762-8199-3017bb6ed936\",\"w\":24,\"x\":24,\"y\":0},\"panelIndex\":\"1132db5f-6fe9-4762-8199-3017bb6ed936\",\"embeddableConfig\":{\"title\":\"\"},\"panelRefName\":\"panel_1\"},{\"version\":\"7.9.3\",\"gridData\":{\"h\":15,\"i\":\"9f0cc291-de38-42f4-b565-e13678cb5a88\",\"w\":24,\"x\":0,\"y\":15},\"panelIndex\":\"9f0cc291-de38-42f4-b565-e13678cb5a88\",\"embeddableConfig\":{\"title\":\"\"},\"panelRefName\":\"panel_2\"},{\"version\":\"7.9.3\",\"gridData\":{\"h\":15,\"i\":\"94b09a97-8775-4886-be22-c1ad53a7e361\",\"w\":24,\"x\":24,\"y\":15},\"panelIndex\":\"94b09a97-8775-4886-be22-c1ad53a7e361\",\"embeddableConfig\":{},\"panelRefName\":\"panel_3\"}]","timeRestore":false,"title":"Dashboard with 3 hidden titles","version":1},"id":"ab7b7bf0-b1e0-11ec-815f-6160134e7be5","migrationVersion":{"dashboard":"7.9.3"},"references":[{"id":"46142a00-b1e0-11ec-815f-6160134e7be5","name":"panel_0","type":"lens"},{"id":"489c0d60-b1e0-11ec-815f-6160134e7be5","name":"panel_1","type":"lens"},{"id":"4a5ca920-b1e0-11ec-815f-6160134e7be5","name":"panel_2","type":"lens"},{"id":"4c349d70-b1e0-11ec-815f-6160134e7be5","name":"panel_3","type":"lens"}],"type":"dashboard","updated_at":"2022-04-01T17:25:04.943Z","version":"WzEzMSwxXQ=="}
{"exportedCount":5,"missingRefCount":0,"missingReferences":[]}

After the migration into main, the dashboard should have 3 hidden titles and one shown:

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort v8.0.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. v8.1.0 v8.2.0 v8.3.0 v7.17.3 labels Apr 5, 2022
@ThomThomson ThomThomson requested a review from a team as a code owner April 5, 2022 21:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

'7.11.0': flow(createExtractPanelReferencesMigration(deps)),

Copy link
Contributor Author

@ThomThomson ThomThomson Apr 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this comment block as it is no longer relevant due to the work @ppisljar did in #103680

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending the change to 7.17.3

@@ -257,14 +307,8 @@ export const createDashboardSavedObjectTypeMigrations = (
'7.0.0': flow(migrations700),
'7.3.0': flow(migrations730),
'7.9.3': flow(migrateMatchAllQuery),
'7.10.0': flow(migrateExplicitlyHiddenTitles),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to happen in 7.17.3 to pick up all the cases of instances that are already past 7.10 who are still having the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's very unlikely that this change will actually be able to fix any cases, due to most of the in-between versions not having #95355, I think this is a good call, just in case. It can't hurt anything.

Will update the version!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit c72a954 into elastic:main Apr 7, 2022
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Apr 7, 2022
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9

(cherry picked from commit c72a954)
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Apr 7, 2022
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9

(cherry picked from commit c72a954)
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Apr 7, 2022
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9

(cherry picked from commit c72a954)
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Apr 7, 2022
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9

(cherry picked from commit c72a954)
ThomThomson added a commit that referenced this pull request Apr 7, 2022
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9

(cherry picked from commit c72a954)
ThomThomson added a commit that referenced this pull request Apr 7, 2022
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9

(cherry picked from commit c72a954)
ThomThomson added a commit that referenced this pull request Apr 7, 2022
* add dashboard migration to explicitly hide the titles on panels whose titles were hidden in 7.9

(cherry picked from commit c72a954)
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 11, 2022
@ThomThomson ThomThomson removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.17.3 v8.1.3 v8.2.0 v8.3.0
Projects
None yet
5 participants