Fix styles for "You do not have permission" screen #129715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomheymann
added
release_note:fix
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
thomheymann
commented
Apr 7, 2022
| @@ -178,7 +178,7 @@ export class AuthorizationService { | |||
| http.registerOnPreResponse((request, preResponse, toolkit) => { | |||
| if (preResponse.statusCode === 403 && canRedirectRequest(request)) { | |||
| const next = `${http.basePath.get(request)}${request.url.pathname}${request.url.search}`; | |||
| const body = renderToStaticMarkup( | |||
| const body = renderToString( | |||
There was a problem hiding this comment.
emotion does not support server side rendering via renderToStaticMarkup() so using renderToString() instead.
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Apr 11, 2022
* Fix styles for "You do not have permission" screen * . Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b5dae38)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 11, 2022
* Fix styles for "You do not have permission" screen * . Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b5dae38) Co-authored-by: Thom Heymann <190132+thomheymann@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #124490
Fix styles for "You do not have permission" screen.
Before
After