-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17] [Observability] [RAC] [Alerts] Resolve bug where "mark as.." for a single alert would redirect to security solution route #130609
[7.17] [Observability] [RAC] [Alerts] Resolve bug where "mark as.." for a single alert would redirect to security solution route #130609
Conversation
…ing the actions dropdown in the t-grid alerts table would be redirected to the security solution detections status route, not the RAC alerts status route
@dhurley14 I confirm that your fix solves the issue. I tested it manually and it works fine. I mark an alert as acknowledged or closed and alert appears under observability acknowledged or closed tab accordingly. Your test is failing though. It gets stuck here, where as you can see under closed tab there are two alerts (metrics and apm) that are read only and that's why the checkbox is disabled. I will approve the PR. Let me know if you need any help fixing the failing test. |
@dhurley14 I did a bit more manual testing with a user role with |
@dhurley14 I just pushed a fix for the forbidden error I posted above. Make sure to pull (or rebase whatever works for you) before you push. |
… into hotfix-single-update-alerts-obs
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @dhurley14 |
Resolves bug where a user updating a single alert in observability using the actions dropdown in the t-grid alerts table would be redirected to the security solution detections status route, not the RAC alerts status route
Bug
If we select the actions for a specific alert, it is redirected to the security solution api due to a logic bug..
Response with a 403:
This PR resolves this bug by correctly redirecting to the RAC alerts route, not the detections alerts route.
Checklist
Delete any items that are not applicable to this PR.
For maintainers