Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] [Observability] [RAC] [Alerts] Resolve bug where "mark as.." for a single alert would redirect to security solution route #130609

Merged
merged 5 commits into from
Apr 20, 2022

Conversation

dhurley14
Copy link
Contributor

Resolves bug where a user updating a single alert in observability using the actions dropdown in the t-grid alerts table would be redirected to the security solution detections status route, not the RAC alerts status route

Bug

If we select the actions for a specific alert, it is redirected to the security solution api due to a logic bug..

403_for_customer

Response with a 403:

403_network_error

This PR resolves this bug by correctly redirecting to the RAC alerts route, not the detections alerts route.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

…ing the actions dropdown in the t-grid alerts table would be redirected to the security solution detections status route, not the RAC alerts status route
@dhurley14 dhurley14 added bug Fixes for quality problems that affect the customer experience review impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Theme: rac label obsolete Feature:Observability RAC v7.17.3 labels Apr 19, 2022
@dhurley14 dhurley14 self-assigned this Apr 19, 2022
@mgiota mgiota self-requested a review April 20, 2022 13:18
@mgiota
Copy link
Contributor

mgiota commented Apr 20, 2022

@dhurley14 I confirm that your fix solves the issue. I tested it manually and it works fine. I mark an alert as acknowledged or closed and alert appears under observability acknowledged or closed tab accordingly.

Your test is failing though. It gets stuck here, where as you can see under closed tab there are two alerts (metrics and apm) that are read only and that's why the checkbox is disabled.
Screenshot 2022-04-20 at 16 08 36

I will approve the PR. Let me know if you need any help fixing the failing test.

@mgiota
Copy link
Contributor

mgiota commented Apr 20, 2022

@dhurley14 I did a bit more manual testing with a user role with Logs: All and Metrics: Read and I get following error
Screenshot 2022-04-20 at 21 03 51

@mgiota
Copy link
Contributor

mgiota commented Apr 20, 2022

@dhurley14 I just pushed a fix for the forbidden error I posted above. Make sure to pull (or rebase whatever works for you) before you push.

@dhurley14 dhurley14 enabled auto-merge (squash) April 20, 2022 20:44
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 311.0KB 311.0KB +4.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dhurley14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Observability RAC impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:fix review Theme: rac label obsolete v7.17.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants