Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data Frame Analytics creation wizard: add support for filters in saved searches #130744

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Apr 20, 2022

Summary

Fixes: #130050

The creation wizard now supports filters in saved searches - these are now reflected in the preview table and passed through to the job config.

Checklist

Delete any items that are not applicable to this PR.

  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes and LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.3MB 3.3MB +440.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@qn895
Copy link
Member

qn895 commented Apr 26, 2022

LGTM 🎉

@alvarezmelissa87 alvarezmelissa87 merged commit d371f3a into elastic:main Apr 26, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 26, 2022
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-support-saved-searches branch April 26, 2022 21:15
dmlemeshko pushed a commit to dmlemeshko/kibana that referenced this pull request May 5, 2022
… saved searches (elastic#130744)

* support savedSearch filters in DFA results

* fix linting error

* fix error when no search has filter but no query
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
… saved searches (elastic#130744)

* support savedSearch filters in DFA results

* fix linting error

* fix error when no search has filter but no query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Data Frame Analytics ML data frame analytics features :ml release_note:enhancement v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Data Frame Analytics creation wizard: add support for filters in saved searches
6 participants