-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Data Frame Analytics creation wizard: add support for filters in saved searches #130744
Merged
alvarezmelissa87
merged 3 commits into
elastic:main
from
alvarezmelissa87:ml-dfa-support-saved-searches
Apr 26, 2022
Merged
[ML] Data Frame Analytics creation wizard: add support for filters in saved searches #130744
alvarezmelissa87
merged 3 commits into
elastic:main
from
alvarezmelissa87:ml-dfa-support-saved-searches
Apr 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:enhancement
:ml
Feature:Data Frame Analytics
ML data frame analytics features
v8.3.0
labels
Apr 20, 2022
Pinging @elastic/ml-ui (:ml) |
...a_frame_analytics/pages/analytics_creation/components/configuration_step/use_saved_search.ts
Show resolved
Hide resolved
...a_frame_analytics/pages/analytics_creation/components/configuration_step/use_saved_search.ts
Show resolved
Hide resolved
alvarezmelissa87
force-pushed
the
ml-dfa-support-saved-searches
branch
from
April 26, 2022 16:18
668880c
to
f40fb58
Compare
peteharverson
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest changes and LGTM
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
qn895
approved these changes
Apr 26, 2022
LGTM 🎉 |
dmlemeshko
pushed a commit
to dmlemeshko/kibana
that referenced
this pull request
May 5, 2022
… saved searches (elastic#130744) * support savedSearch filters in DFA results * fix linting error * fix error when no search has filter but no query
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
… saved searches (elastic#130744) * support savedSearch filters in DFA results * fix linting error * fix error when no search has filter but no query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Feature:Data Frame Analytics
ML data frame analytics features
:ml
release_note:enhancement
v8.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #130050
The creation wizard now supports filters in saved searches - these are now reflected in the preview table and passed through to the job config.
Checklist
Delete any items that are not applicable to this PR.