-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add "Label" column + filter to Agent list table #131070
[Fleet] Add "Label" column + filter to Agent list table #131070
Conversation
@elasticmachine merge upstream |
@nimarezainia @narph What is the correct naming to use here, I see |
Figma designs call for |
I did some setup preparing for filtering by tags in c43d60c. This is blocked by the Fleet Server work though, since we can't filter on I've also elected to rename |
I think we should keep some consistency on both sides , as decided in elastic/elastic-agent#149 (comment) which is |
Pinging @elastic/fleet (Team:Fleet) |
looks great! some unit tests would be nice. |
Adding UI tests for the entire table seems like it might be a difficult undertaking to include along with this PR, but I did add some basic tests for the Here's the filtering working with pagination: Screen.Recording.2022-05-09.at.10.03.42.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and it looks good to me 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @kpollich |
* Add basic labels implementation for Agent list table * Lay plumbing for filtering based on tags Ref elastic#130717 * Finalize wiring up tags to API * Fix render error when tags empty * Add test for tags component Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Resolves #130713
Resolves #130717
Finalized implementation blocked by elastic/fleet-server#1350
Adds a baseline implementation for listing
tags
stored in.fleet-agents
documents in the Agent listing UI and filtering based on tags.Generating Test Data
You'll need to create a user with the system indices superuser role, then you can add some sample tags to your agents via Kibana dev tools, e.g.
Screenshots
Example values:
Tooltip when hovering truncated list of tags:
KQL autocompletion support:
Screen recording demonstrating filtering behavior:
Screen.Recording.2022-05-09.at.8.54.44.AM.mov