Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Cleanup action types and use one document per action instead of one per agent #131826

Merged
merged 4 commits into from
May 10, 2022
Merged

[Fleet] Cleanup action types and use one document per action instead of one per agent #131826

merged 4 commits into from
May 10, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented May 9, 2022 •
edited
Loading

Related to #130259

Some preliminary work for implementing rolling upgrade:

  • Remove some old types that where unused (before Fleet server was a thing)
  • Change bulk actions to create one document instead of one per agent.

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 labels May 9, 2022
@nchaulet nchaulet self-assigned this May 9, 2022
@nchaulet nchaulet marked this pull request as ready for review May 9, 2022 17:50
@nchaulet nchaulet requested a review from a team as a code owner May 9, 2022 17:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet mentioned this pull request May 9, 2022
Closed
30 tasks
juliaElastic
juliaElastic approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1274 1266 -8
Unknown metric groups

API count

id before after diff
fleet 1394 1388 -6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 425838b into elastic:main May 10, 2022
@nchaulet nchaulet deleted the cleanup-unused-action-type branch May 10, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchaulet @elasticmachine @kibana-ci @juliaElastic @kibanamachine