[Session View] Close session viewer button fixes #131910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opauloh
added
bug
kqualters-elastic
approved these changes
May 12, 2022
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
May 12, 2022
(cherry picked from commit dea7c19)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 12, 2022
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
May 16, 2022
opauloh
added
the
Team: AWP: Visualization
|
Hi @kqualters-elastic @opauloh, We have Validated this issue on #130140 and it's working fine ✅. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR address fixes to #131102 by:
Close sessionbutton text toClose session viewer.<EuiHorizontalRule/>and<EuiSpacer/>before and after theClose session viewerbutton.Screenshots
Close session viewer button on hosts page
Close session viewer button on fullscreen mode
Close session viewer button on timelines
Close session viewer button on users page
Additional Checks