Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Swap around dimensions for mosaic #131945

Merged
merged 2 commits into from
May 11, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #127334

With this change the top level bucket dimension is rendered as rows and the nested bucket dimension as columns. This increases the chances of the row terms being present in every column which is the main use case of mosaic charts:
Screenshot 2022-05-10 at 17 37 51

@flash1293 flash1293 added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting v8.3.0 labels May 10, 2022
@flash1293 flash1293 marked this pull request as ready for review May 10, 2022 17:08
@flash1293 flash1293 requested a review from a team as a code owner May 10, 2022 17:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +57.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit ae944f4 into elastic:main May 11, 2022
academo pushed a commit to academo/kibana that referenced this pull request May 12, 2022
Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Reverse terms nesting for mosaic
4 participants