Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Telemetry] Add telemetry around the time it is taking for grabbing the telemetry stats #131949

Closed
wants to merge 49 commits into from
Closed

[Telemetry] Add telemetry around the time it is taking for grabbing the telemetry stats #131949

wants to merge 49 commits into from

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented May 10, 2022 •
edited
Loading

[IGNORE] CLOSED

Sorry about the noise please ignore this PR

@Bamieh Bamieh added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 labels May 10, 2022
@Bamieh Bamieh force-pushed the telemetry/collection_duration branch from 5adcef8 to ede8c7b Compare May 12, 2022 13:18
@Bamieh Bamieh marked this pull request as ready for review May 12, 2022 13:44
@Bamieh Bamieh requested review from a team as code owners May 12, 2022 13:44
@Bamieh Bamieh changed the title finish implementation [Telemetry] Add telemetry around the time it is taking for grabbing the telemetry stats May 12, 2022
CohenIdo and others added 13 commits May 16, 2022 14:32
@CohenIdo @Bamieh
[Cloud Posture] update CSP rules configuration template
47ab510
@jeramysoucy @Bamieh
Resolves UI Breaks from Malformed Roles (elastic#131915)
10b7200 
* Adds catch of exceptions from PrivilegeSerializer deserialize methods to role transform function.
Resolves 124808 where malformed Elasticsearch roles cause Kibana users and roles UIs to not display correctly.

* Adds logger to role transform functions

* File accidentally not saved prior to last commit
@Kerry350 @Bamieh
[Stack Monitoring] Fix error handling on pipelines page (elastic#132055)
c89fbae 
* Fix error handling on pipelines page
@SergeyKleyman @Bamieh
Fixed typo in Kibana's APM PHP Agent configuration page (elastic#132122)
185ce8a
@miltonhultgren @kibanamachine @Bamieh
[Stack Monitoring] Prevent exceptions in rule when no data present (e…
234d8eb 
…lastic#131332)

* [Stack Monitoring] Prevent exceptions in rule when no data present (elastic#120111)

* Remove optional chaining

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@Bamieh
skip flaky jest suite (elastic#131346)
3dbcc7c
@jughosta @kibanamachine @Bamieh
[Discover][Alerting] Prevent rule flyout from being open simultaneous…
a55bd57 
…ly with other popovers like search suggestions (elastic#132108)

* [Discover][Alerting] Prevent rule flyout from being open simultaneously with other popovers like search suggestions

* [Discover][Alerting] Update tests

* [Discover][Alerting] Update tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@mgiota @Bamieh
[Actionable Observability] Application usage for Alerts, Cases, Rules…
08d9c6d 
… views (elastic#132006)

* add application usage to observability

* wrap Alerts page in a TrackApplicationView component

* define alerting pages in a config file

* add UsageCollectionSetup contract

* pass useCollection in the renderApp

* fix failing tests

* application usage for cases and rules
@nreese @kibanamachine @Bamieh
[Maps] fix Map panels should not show the user controls in a dashboar…
061b53f 
…d report (elastic#131970)

* [Maps] fix Map panels should not show the user controls in a dashboard report

* fix jest tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@parkiino @Bamieh
[Security Solution][Admin][Policy] Fixes a bug where the last side na…
4ceb8d5 
…v item is hidden by the policy details sticky save bar (elastic#131646)
@stratoula @Bamieh
Controls fixes the flakiness (elastic#132107)
2816eb6
@lcawl @Bamieh
Minor UI text edits in Cases (elastic#132074)
d53b3aa
@kqualters-elastic @Bamieh
Make some data fetching hooks state updates atomic (elastic#132069)
50ae706
@Bamieh Bamieh requested review from a team as code owners May 16, 2022 11:39
@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team labels May 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@Bamieh
Copy link
Member Author

Bamieh commented May 16, 2022

Sorry about the noise. rebased from my fork which was heavily outdated 😬 Closing. Will open a fresh PR with the relevant changes only

@Bamieh Bamieh closed this May 16, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 16, 2022 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 426 427 +1
cloudSecurityPosture 183 185 +2
expressionXY 91 92 +1
securitySolution 2811 2920 +109
sessionView 106 107 +1
total +114

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
controls 197 204 +7
embeddable 388 396 +8
observability 371 373 +2
triggersActionsUi 322 325 +3
visualizations 350 351 +1
total +21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB -5.0B
cases 296.8KB 298.3KB +1.5KB
cloudSecurityPosture 180.7KB 182.3KB +1.6KB
controls 420.2KB 420.8KB +600.0B
dataViewEditor 169.4KB 170.7KB +1.4KB
enterpriseSearch 1.5MB 1.5MB +889.0B
expressionXY 56.4KB 60.5KB +4.1KB
fleet 704.6KB 704.6KB -15.0B
indexManagement 515.5KB 515.5KB +6.0B
maps 2.5MB 2.5MB +100.0B
observability 435.0KB 436.2KB +1.2KB
presentationUtil 127.3KB 127.4KB +74.0B
securitySolution 4.8MB 5.0MB +139.3KB
sessionView 64.7KB 70.0KB +5.2KB
total +156.0KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
triggersActionsUi 29 30 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 112.2KB 112.1KB -33.0B
cloudSecurityPosture 4.6KB 4.5KB -134.0B
controls 30.6KB 31.8KB +1.2KB
core 300.0KB 300.2KB +223.0B
embeddable 65.9KB 66.2KB +387.0B
enterpriseSearch 20.6KB 20.9KB +294.0B
expressionXY 29.1KB 28.9KB -272.0B
kbnUiSharedDeps-css 594.5KB 589.9KB -4.5KB
kbnUiSharedDeps-npmDll 4.8MB 4.8MB +3.0KB
maps 78.0KB 78.1KB +128.0B
newsfeed 9.9KB 10.0KB +131.0B
observability 92.0KB 92.2KB +179.0B
securitySolution 246.6KB 246.7KB +134.0B
timelines 272.6KB 272.6KB +20.0B
triggersActionsUi 101.1KB 101.1KB +48.0B
visualizations 46.5KB 46.5KB +10.0B
total +825.0B
Unknown metric groups

API count

id before after diff
controls 203 210 +7
embeddable 478 486 +8
observability 374 376 +2
triggersActionsUi 336 339 +3
visualizations 371 372 +1
total +21

async chunk count

id before after diff
expressionXY 5 6 +1
securitySolution 23 29 +6
total +7

miscellaneous assets size

id before after diff
securitySolution 1.5MB 1.7MB +161.8KB

References to deprecated APIs

id before after diff
securitySolution 54 48 -6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh deleted the telemetry/collection_duration branch May 16, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo left review comments

@ashokaditya ashokaditya Awaiting requested review from ashokaditya ashokaditya was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

@dasansol92 dasansol92 Awaiting requested review from dasansol92 dasansol92 was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet