[Lens] Datatable: Do not apply truncation in value popover

[flash1293]

Fixes #131937

This PR makes sure the truncation mixin is only applied to the actual cell in the data grid, not the popover. This makes sure a value that's too large for the cell can be viewed in its entirety in the popover:

Before

After

[elasticmachine]

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

[MichaelMarcialis]

Thanks, @flash1293. Leaving one question below for your review.

[MichaelMarcialis]

I feel like we shouldn't be using the data-test-subj attribute as a selector for styles. Would it be possible to apply a new class instead?

[flash1293]

Thanks for the review @MichaelMarcialis , fixed

[MichaelMarcialis]

Thanks for making that change, @flash1293.

Forgive me, but I have one follow-up question. I was under the impression that EuiDataGrid handled the truncation of data grid cell contents natively, and (to my knowledge) does not carry forward that truncation to the cell popovers. If that is true, why are we running with our own truncation implementation here rather than using the native data grid truncation?

[flash1293]

@elasticmachine merge upstream

[flash1293]

@MichaelMarcialis AFAIK this is happening because we are breaking out of the default handling for the cell contents because a bunch of custom things are happening for the Lens table (alignment, coloring, ...):

kibana/x-pack/plugins/lens/public/datatable_visualization/components/cell_value.tsx

Line 83 in 3730dd0

data-test-subj="lnsTableCellContent"

[flash1293]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: cc0d67b
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.1MB	1.1MB	+46.0B

History

• 💚 Build #44971 succeeded ba9516b
• 💚 Build #44332 succeeded 567a73c
• 💚 Build #43953 succeeded c932142

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream