Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVB] Chart is failing when the user tries to add a percentile_rank #132105

Merged
merged 1 commit into from
May 12, 2022
Merged

TSVB] Chart is failing when the user tries to add a percentile_rank #132105

merged 1 commit into from
May 12, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 12, 2022 •
edited
Loading

Closes: #131999

Describe the bug:

  1. Open a new TSVB viz, there is always a default first layer (count(
  2. Change the first layer aggregation to percentile rank
  3. Try to add a field
  4. Field is not added and I can see an incorrect warning

image

8. Even if I remove the warning I can't make my TSVB chart to work

Errors in browser console (if relevant):

image

Screens:

@alexwizp alexwizp requested a review from stratoula May 12, 2022 09:15
@alexwizp alexwizp self-assigned this May 12, 2022
@alexwizp alexwizp added v8.3.0 Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 12, 2022
@alexwizp alexwizp added the backport:skip This commit does not require backporting label May 12, 2022
stratoula
stratoula approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested it locally and bug is fixed! Thanx Alex :)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeTimeseries 465.3KB 465.3KB -9.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

@alexwizp alexwizp marked this pull request as ready for review May 12, 2022 10:56
@alexwizp alexwizp requested a review from a team as a code owner May 12, 2022 10:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@alexwizp alexwizp merged commit d46d101 into elastic:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

@alexwizp alexwizp

Labels
backport:skip This commit does not require backporting Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TSVB] Chart is failing when the user tries to add a percentile_rank
4 participants
@alexwizp @kibana-ci @elasticmachine @stratoula