[Dashboard] Add Analytics No Data Page #132188
Conversation
…and dashboard listing page
ThomThomson
added
release_note:enhancement
Feature:Dashboard
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
| // loadTestFile(require.resolve('./dashboard_time')); | ||
| // loadTestFile(require.resolve('./dashboard_listing')); | ||
| // loadTestFile(require.resolve('./dashboard_clone')); |
There was a problem hiding this comment.
Is there a reason these other tests are commented out?
There was a problem hiding this comment.
I commented them out just for testing purposes. That would have been bad. Thank you for catching this.
| return true; | ||
| } | ||
|
|
||
| const defaultDataView = await dataViews.getDefaultDataView(); |
There was a problem hiding this comment.
is this check necessary for Dashboard?
There was a problem hiding this comment.
That's a good question. The older version of this code had an ensureDefaultDataView check, so it seems to have been required before, but I can't exactly understand why. If there are any data views, surely one of them should be default, no?
Is there a reason this was required for Discover?
There was a problem hiding this comment.
if memory serves well, in Discover, you save a saved search with a data view. if all data views get deleted and you try opening a saved search, that would throw an error. That's why the check. That being said, it was there before checking for existence of any data view, so I am not sure if it's relevant any more.
There was a problem hiding this comment.
Seems like it should all work the same. I will remove this from the dashboard side!
| ); | ||
| }; | ||
|
|
||
| export const isDashboardAppEmpty = async (dataViews: DataPublicPluginStart['dataViews']) => { |
There was a problem hiding this comment.
just a nit: we're trying to standardize terminology in a way that by "no data" we refer to "there is no data in ES or there are no data views". by "empty" we refer to "this app is empty", aka there is data, but there are no dashboards yet. can we rename this to something like "noDataCheck" or "hasData" or even "canUseDashboard"?
There was a problem hiding this comment.
Ah, I will rename all of these. Naming is important, thank you for pointing this out!
| @@ -47,7 +47,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { | |||
| indices: [ | |||
| { | |||
| names: ['ecommerce', 'kibana_sample_data_ecommerce'], | |||
| privileges: ['read'], | |||
| privileges: ['read', 'view_index_metadata'], | |||
There was a problem hiding this comment.
Let's not change permissions here as this is a valid test case that caught a pretty big error.
There was a problem hiding this comment.
Aye aye, will undo this now that the fix is merged in!
|
The Can you try removing the additional privilege in the functional test and see if this works? |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Unknown metric groupsasync chunk count
miscellaneous assets size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
I pushed a commit that re-introduces a check for default data view. That actually does more than just check for one; it loads a default data view if there is none. This is needed in case of switching spaces, where a wrong data view could stay associated with the dashboard and dashboard would try to load the data from the data view from a previous space (which doesn't exist in a current space). Sorry for leading you down the wrong path.
Also approving this for no data changes, so that it doesn't block merging.
Fixes #132144
Summary
Adopts the Shared UX no data component in the Dashboard listing page, and in the dashboard app.
Add integrations callout in dashboard
Creating a Data View from the create Dashboard route
Creating a Data View from the Dashboard Listing route
Checklist
Delete any items that are not applicable to this PR.