[Management] Update saved objects client usage to attributes instead of _source
#13223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`. Also, fixing an improper "safe" apply usage.
|
Please backport to 5.6 as well. |
spalger
reviewed
Jul 31, 2017
| @@ -152,7 +152,7 @@ uiModules.get('apps/management') | |||
| $scope.aceInvalidEditors = _.without($scope.aceInvalidEditors, fieldName); | |||
| } | |||
|
|
|||
| if ($rootScope.$$phase) $scope.$apply(); | |||
| if (!$rootScope.$$phase) $scope.$apply(); | |||
chrisronline
added a commit
that referenced
this pull request
Jul 31, 2017
…`. Also, fixing an improper "safe" apply usage. (#13223)
chrisronline
added a commit
that referenced
this pull request
Jul 31, 2017
…`. Also, fixing an improper "safe" apply usage. (#13223)
chrisronline
added a commit
that referenced
this pull request
Jul 31, 2017
…`. Also, fixing an improper "safe" apply usage. (#13223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13186
Summary
We recently introduced a saved objects client to replace direct courier usage, but it looks we missed an area that needed to be updated to handle part of the breaking changes.
This PR refactors old usage of
_sourceto updatedattributessince this page uses the saved objects client directly.Also, there seemed to be an improper "safe" apply happening that was introduced awhile ago
Testing
Try editing and saving a saved dashboard within Saved Objects