Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitor Management] Don't show required error on Script Field before field is touched. #132339

Merged
merged 1 commit into from
May 18, 2022
Merged

[Monitor Management] Don't show required error on Script Field before field is touched. #132339

merged 1 commit into from
May 18, 2022

Conversation

awahab07
Copy link
Contributor

Now that the Browser type will be the default monitor type for Synthetics, Script field should not show a required validation error until it is touched/changed.

The CodeEditor component doesn't expose onBlur so the PR makes use of onChange to show required validation error only after code is changed.

Also, with Zip Url field as well, only shows validation error if it was touched (onBlur).

The above two changes will only be effective under uptime. Under fleet, the form fields aren't changed.

@awahab07 awahab07 requested a review from a team as a code owner May 17, 2022 15:17
@awahab07 awahab07 added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated: Automatically backport this PR after it's merged v8.3.0 labels May 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@awahab07 awahab07 changed the title Only show script or zip source 'required' validation error after fiel… [Monitor Management] Don't show required error on Script Field before field is touched. May 17, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 792.4KB 792.6KB +205.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dominiqueclarke
dominiqueclarke approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awahab07 awahab07 merged commit a989e20 into elastic:main May 18, 2022
kibanamachine pushed a commit that referenced this pull request May 18, 2022
@awahab07
Only show script or zip source 'required' validation error after fiel…
4417701 
…d is touched/changed. (#132339)

(cherry picked from commit a989e20)
@kibanamachine kibanamachine mentioned this pull request May 18, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 18, 2022
@kibanamachine @awahab07
Only show script or zip source 'required' validation error after fiel…
71f7f44 
…d is touched/changed. (#132339) (#132415)

(cherry picked from commit a989e20)

Co-authored-by: Abdul Wahab Zahid <awahab07@yahoo.com>
@shahzad31
Copy link
Contributor

POST FF Testing, found an issue where it wasn't showing validation error for script field on submit form

raised a PR to fix it

#133558

image

@shahzad31 shahzad31 mentioned this pull request Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.1 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@awahab07 @elasticmachine @kibana-ci @kibanamachine @shahzad31 @dominiqueclarke