Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Script field, updated validation and width #133558

Merged
merged 4 commits into from
Jun 8, 2022
Merged

[Synthetics] Script field, updated validation and width #133558

merged 4 commits into from
Jun 8, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jun 3, 2022 •
edited
Loading

Fixes #132339

Show validation error on submit

Also increased the script field width to make it more manage-bale

Before:
image

After:
image

@shahzad31 shahzad31 mentioned this pull request Jun 7, 2022
Merged
@shahzad31 shahzad31 marked this pull request as ready for review June 7, 2022 12:15
@shahzad31 shahzad31 requested a review from a team as a code owner June 7, 2022 12:16
@shahzad31 shahzad31 changed the title updated validation and width [Synthetics] Script field, updated validation and width Jun 7, 2022
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 v8.4.0 labels Jun 7, 2022
@awahab07 awahab07 force-pushed the fix-script-field-validation branch from 8bb7a90 to a86bdb5 Compare June 7, 2022 17:36
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 858.1KB 858.2KB +73.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

awahab07
awahab07 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahzad31 shahzad31 merged commit 3aa0e71 into elastic:main Jun 8, 2022
@shahzad31 shahzad31 deleted the fix-script-field-validation branch June 8, 2022 14:04
@shahzad31 shahzad31 added the auto-backport Deprecated: Automatically backport this PR after it's merged label Jun 8, 2022
kibanamachine pushed a commit that referenced this pull request Jun 8, 2022
@shahzad31
[Synthetics] Script field, updated validation and width (#133558)
fbbfa41 
Co-authored-by: Abdul Zahid <awahab07@yahoo.com>
(cherry picked from commit 3aa0e71)
@kibanamachine kibanamachine mentioned this pull request Jun 8, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 9, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 13, 2022
kibanamachine added a commit that referenced this pull request Jun 13, 2022
@kibanamachine @shahzad31
[Synthetics] Script field, updated validation and width (#133558) (#1…
bf17c41 
…33896)

Co-authored-by: Abdul Zahid <awahab07@yahoo.com>
(cherry picked from commit 3aa0e71)

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
@LeeDr LeeDr added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@shahzad31 @kibana-ci @kibanamachine @elasticmachine @awahab07 @LeeDr