-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Cache ES snapshots on agents #132940
Conversation
…to es-snapshot-cache
Pinging @elastic/kibana-operations (Team:Operations) |
@elasticmachine merge upstream |
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
@@ -35,7 +35,10 @@ async function upToDate(settingsPath: string) { | |||
|
|||
export async function setupRemoteCache(repoRootPath: string) { | |||
// The remote cache is only for Elastic employees working locally (CI cache settings are handled elsewhere) | |||
if (process.env.CI || !(await isElasticCommitter())) { | |||
if ( | |||
process.env.FORCE_BOOTSTRAP_REMOTE_CACHE !== 'true' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting side effect here gives third party devs an easy option to enable remote bazel caching without using a fake Elastic email, in case any of them are lurking about :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This didn't make 8.2.2 removing the label. Thanks @brianseeders |
(cherry picked from commit 60226bc)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
We have so many agents that run functional tests, downloading ES snapshots in all of them is a huge usage of bandwidth. We recently moved away from Cloud NAT for this reason. It was very expensive because of the bandwidth usage. It also costs a lot on the GCS bucket when we download them from other regions. This caches the snapshots in our agent images so that we don't need to download them most of the time.