Prevents default index pattern name when ID is provided #13353

tylersmalley · 2017-08-04T21:29:35Z

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley · 2017-08-08T15:56:37Z

...ugins/kibana/public/management/sections/indices/create_index_pattern/create_index_pattern.js

@@ -30,15 +30,23 @@ uiModules.get('apps/management')

  // Configure the new index pattern we're going to create.
  this.formValues = {
-    id: $routeParams.id ? decodeURIComponent($routeParams.id) : undefined,
+    id: undefined,


I suppose I could remove this

jbudz · 2017-08-08T16:14:34Z

Is this expected?

jbudz · 2017-08-08T16:15:53Z

Nevermind, wrong page. Do you have reproduction steps?

tylersmalley · 2017-08-08T16:21:40Z

Yes, reproduction steps would be good.

By visiting the create index pattern page with an id provided as a query parameter.

Example: http://localhost:5601/app/kibana#/management/kibana/index?_g=()&id=ABC123

You should see the id advanced settings expanded with ABC123 filled out for the ID, and the index pattern should be blank.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

BigFunger · 2017-08-16T15:18:59Z

...ugins/kibana/public/management/sections/indices/create_index_pattern/create_index_pattern.js

@@ -30,15 +30,22 @@ uiModules.get('apps/management')

  // Configure the new index pattern we're going to create.
  this.formValues = {
-    id: $routeParams.id ? decodeURIComponent($routeParams.id) : undefined,
    name: config.get('indexPattern:placeholder'),


Why not follow the same pattern that was there?
name: $routeParams.id ? '' : config.get('indexPattern:placeholder')

I felt like it was more straightforward to have a block which describes a scenario where the defaults were changed than to use inline if's. I am fine changing it if you think it reads better as inline if's.

chrisronline

I agree with Jim's suggestion, but otherwise, LGTM

BigFunger

LGTM

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley · 2017-08-16T16:54:37Z

5.6: 8040254
6.0: ae11e48
6.x/6.1: 1de8b7e

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

) Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Create Index Pattern Creation wizard. - Create a directive for each step in the wizard. - Reorganize files into conventional folder structure. - Rename files with more conventional and consistent naming patterns. - Display indices, partial matches, exact matches. - Add loading, empty, and success states. - Add option to include system indices. * Temp: comment out and mock getIndices functionality. * Hook up data seaching * Add for/id connections for form inputs and labels * Automatically append a wildcard * Highlight the index pattern in the results * Ensure we only remove the last character if it's a `*` * Auto hide index pattern id controls * Ensure this link is tabbable * Move the advanced fields down * Use toggle button * This shouldn't ever be required * Revert "This shouldn't ever be required" This reverts commit b6e31e7. * Update based on comments in PR * Ffew more changes * Port changes from Tyler's PR, #13353 * Remove unnecessary file * Fix broken functional tests * Copy changes * Fix functional tests * Remove loading from the main select, and move to an additional select * Show help text when loading * Fix sorting * Fixing broken functional tests * Couple changes from PR review * Ensure input field does not show a red border until touched * More descriptive and consistent copy

* Create Index Pattern Creation wizard. - Create a directive for each step in the wizard. - Reorganize files into conventional folder structure. - Rename files with more conventional and consistent naming patterns. - Display indices, partial matches, exact matches. - Add loading, empty, and success states. - Add option to include system indices. * Temp: comment out and mock getIndices functionality. * Hook up data seaching * Add for/id connections for form inputs and labels * Automatically append a wildcard * Highlight the index pattern in the results * Ensure we only remove the last character if it's a `*` * Auto hide index pattern id controls * Ensure this link is tabbable * Move the advanced fields down * Use toggle button * This shouldn't ever be required * Revert "This shouldn't ever be required" This reverts commit b6e31e79308271e7f04ea1d42ce66e32e7aa0612. * Update based on comments in PR * Ffew more changes * Port changes from Tyler's PR, elastic/kibana#13353 * Remove unnecessary file * Fix broken functional tests * Copy changes * Fix functional tests * Remove loading from the main select, and move to an additional select * Show help text when loading * Fix sorting * Fixing broken functional tests * Couple changes from PR review * Ensure input field does not show a red border until touched * More descriptive and consistent copy

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Create Index Pattern Creation wizard. - Create a directive for each step in the wizard. - Reorganize files into conventional folder structure. - Rename files with more conventional and consistent naming patterns. - Display indices, partial matches, exact matches. - Add loading, empty, and success states. - Add option to include system indices. * Temp: comment out and mock getIndices functionality. * Hook up data seaching * Add for/id connections for form inputs and labels * Automatically append a wildcard * Highlight the index pattern in the results * Ensure we only remove the last character if it's a `*` * Auto hide index pattern id controls * Ensure this link is tabbable * Move the advanced fields down * Use toggle button * This shouldn't ever be required * Revert "This shouldn't ever be required" This reverts commit b6e31e7. * Update based on comments in PR * Ffew more changes * Port changes from Tyler's PR, elastic#13353 * Remove unnecessary file * Fix broken functional tests * Copy changes * Fix functional tests * Remove loading from the main select, and move to an additional select * Show help text when loading * Fix sorting * Fixing broken functional tests * Couple changes from PR review * Ensure input field does not show a red border until touched * More descriptive and consistent copy

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

* Create Index Pattern Creation wizard. - Create a directive for each step in the wizard. - Reorganize files into conventional folder structure. - Rename files with more conventional and consistent naming patterns. - Display indices, partial matches, exact matches. - Add loading, empty, and success states. - Add option to include system indices. * Temp: comment out and mock getIndices functionality. * Hook up data seaching * Add for/id connections for form inputs and labels * Automatically append a wildcard * Highlight the index pattern in the results * Ensure we only remove the last character if it's a `*` * Auto hide index pattern id controls * Ensure this link is tabbable * Move the advanced fields down * Use toggle button * This shouldn't ever be required * Revert "This shouldn't ever be required" This reverts commit b6e31e7. * Update based on comments in PR * Ffew more changes * Port changes from Tyler's PR, elastic#13353 * Remove unnecessary file * Fix broken functional tests * Copy changes * Fix functional tests * Remove loading from the main select, and move to an additional select * Show help text when loading * Fix sorting * Fixing broken functional tests * Couple changes from PR review * Ensure input field does not show a red border until touched * More descriptive and consistent copy

tylersmalley added review v5.6.0 v6.0.0 v6.1.0 v7.0.0 labels Aug 4, 2017

Prevents default index pattern name when ID is provided

9d87625

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley force-pushed the prevent-index-pattern-default branch from 7b77b0b to 9d87625 Compare August 4, 2017 21:37

tylersmalley commented Aug 8, 2017

View reviewed changes

jbudz approved these changes Aug 8, 2017

View reviewed changes

No reason to set id to undefined

35ce5d3

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley added the :Management label Aug 15, 2017

chrisronline self-requested a review August 16, 2017 15:15

BigFunger suggested changes Aug 16, 2017

View reviewed changes

chrisronline approved these changes Aug 16, 2017

View reviewed changes

BigFunger approved these changes Aug 16, 2017

View reviewed changes

tylersmalley merged commit 911467a into elastic:master Aug 16, 2017

tylersmalley added a commit that referenced this pull request Aug 16, 2017

Prevents default index pattern name when ID is provided (#13353)

1de8b7e

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley added a commit that referenced this pull request Aug 16, 2017

Prevents default index pattern name when ID is provided (#13353)

ae11e48

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley added a commit to tylersmalley/kibana that referenced this pull request Aug 16, 2017

Prevents default index pattern name when ID is provided (elastic#13353)

a8d682f

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley mentioned this pull request Aug 16, 2017

[backport] Prevents default index pattern name when ID is provided (#13353) #13534

Merged

tylersmalley added a commit that referenced this pull request Aug 16, 2017

Prevents default index pattern name when ID is provided (#13353) (#13534

8040254

) Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

chrisronline added a commit to chrisronline/kibana that referenced this pull request Aug 16, 2017

Port changes from Tyler's PR, elastic#13353

9b27cf1

chrisronline added a commit to chrisronline/kibana that referenced this pull request Aug 22, 2017

Port changes from Tyler's PR, elastic#13353

689ab22

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017

Prevents default index pattern name when ID is provided (elastic#13353)

76c8078

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017

Prevents default index pattern name when ID is provided (elastic#13353)

a1df068

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevents default index pattern name when ID is provided #13353

Prevents default index pattern name when ID is provided #13353

tylersmalley commented Aug 4, 2017

tylersmalley Aug 8, 2017

jbudz commented Aug 8, 2017

jbudz commented Aug 8, 2017 •

edited

Loading

tylersmalley commented Aug 8, 2017

BigFunger Aug 16, 2017

tylersmalley Aug 16, 2017 •

edited

Loading

chrisronline left a comment

BigFunger left a comment

tylersmalley commented Aug 16, 2017 •

edited

Loading

Prevents default index pattern name when ID is provided #13353

Prevents default index pattern name when ID is provided #13353

Conversation

tylersmalley commented Aug 4, 2017

tylersmalley Aug 8, 2017

Choose a reason for hiding this comment

jbudz commented Aug 8, 2017

jbudz commented Aug 8, 2017 • edited Loading

tylersmalley commented Aug 8, 2017

BigFunger Aug 16, 2017

Choose a reason for hiding this comment

tylersmalley Aug 16, 2017 • edited Loading

Choose a reason for hiding this comment

chrisronline left a comment

Choose a reason for hiding this comment

BigFunger left a comment

Choose a reason for hiding this comment

tylersmalley commented Aug 16, 2017 • edited Loading

jbudz commented Aug 8, 2017 •

edited

Loading

tylersmalley Aug 16, 2017 •

edited

Loading

tylersmalley commented Aug 16, 2017 •

edited

Loading