-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix normalizers to not parse list values if they are already parsed #133563
Fix normalizers to not parse list values if they are already parsed #133563
Conversation
Pinging @elastic/uptime (Team:uptime) |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and it works as expected now !!
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Fixes #133212
Summary
While configuring a Synthetics Integration via yaml, the list values (e.g.
ssl.supported_protocols
under TLS Configuration of HTTP monitor ortags
for any monitor) are re-parsed via JSON.parse when they were already parsed and converted to a JS Array by js-yaml, causing the following error on Synthetics Integration Edit Page:This PR fixes this and before applying JSON.parse, first checks if the value is already parsed.
How to test
kibana.dev.yml
, put the following Synthetics Integration configNote: There's an issue with the UI that on editing a yaml configured integration, the Tags or Supported TLS protocols combobox shows invalid state with
"elastic"
as an option value. As shown below:Turned out it is the browser autofill which puts
"elastic"
as the default value. The default value"elastic"
comes from Kibana's username input field as both input fields (the username and the one contained within EuiComoBox component) are unnamed. Eui team has been informed about this as there should be an option to setautocomplete="off"
on EuiComboBox component.