New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infrastructure UI][Rules] Fix viewInAppUrl for custom metrics for Inventory Threshold Rule #134114

Merged

simianhacker merged 5 commits into elastic:main from simianhacker:issue-134110-fix-broken-inventory-view-in-app-url

Jun 16, 2022

Member

simianhacker commented Jun 9, 2022 •

edited

Loading

Summary

This PR fixes #134110 by fixing a faulty if condition in the link creation function.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

simianhacker added 2 commits

June 9, 2022 14:47


          [Infrastructure UI][Rules] Fix viewInAppUrl for custom metrics for In…

44cd5cd

…ventory Threshold Rule


          Adding test for generating link, moving custom field inside if statement

5eed1d7

simianhacker added v8.4.0 v8.3.1 Feature:Metrics UI Team: Actionable Observability - DEPRECATED release_note:fix labels


          Merge branch 'main' of github.com:elastic/kibana into issue-134110-fi…

f37597a

…x-broken-inventory-view-in-app-url

mgiota reviewed

View reviewed changes

x-pack/plugins/infra/common/alerting/metrics/alert_link.ts

    
                  const criteriaCustomMetricId = fields[`${ALERT_RULE_PARAMETERS}.criteria.customMetric.id`][0];

                  if (criteriaCustomMetricId !== 'alert-custom-metric') {

                  if (criteriaMetric === 'custom') {

                    const criteriaCustomMetricId = fields[`${ALERT_RULE_PARAMETERS}.criteria.customMetric.id`][0];

Contributor

mgiota Jun 13, 2022

@simianhacker This change looks reasonable to me. I am just wondering how it used to work in the first place. Here's the PR that introduced this change https://github.com/elastic/kibana/pull/113553/files#diff-173c0f4e56c53ef08415cbd7e2a1773b2bd84596e5c366be4fb55507d33265fdR2. I'll take a closer look

Member Author

simianhacker Jun 13, 2022

I'm not sure why it was written that way, probably just a misunderstanding of how the custom metric stuff works.

simianhacker marked this pull request as ready for review

June 13, 2022 14:53

simianhacker requested a review from a team as a code owner

June 13, 2022 14:53

Contributor

elasticmachine commented Jun 13, 2022

Pinging @elastic/actionable-observability (Team: Actionable Observability)

Member Author

simianhacker commented Jun 13, 2022

@elasticmachine merge upstream


          Merge branch 'main' into issue-134110-fix-broken-inventory-view-in-ap…

17c633c

…p-url

simianhacker enabled auto-merge (squash)

June 13, 2022 14:54

klacabane self-requested a review

June 16, 2022 15:13

Contributor

klacabane commented Jun 16, 2022

@elasticmachine merge upstream


          Merge branch 'main' into issue-134110-fix-broken-inventory-view-in-ap…

e1fc374

…p-url

klacabane approved these changes

View reviewed changes

Contributor

klacabane left a comment

tested on an inventory rule with system.process.cpu.total.value custom metric - lgtm

Collaborator

kibana-ci commented Jun 16, 2022

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`infra`	83.9KB	83.9KB	-13.0B

History

💚 Build #50531 succeeded 17c633c
💚 Build #50272 succeeded f37597a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

simianhacker merged commit a020f05 into elastic:main

kibanamachine added the backport missing label

Contributor

kibanamachine commented Jun 20, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

7 similar comments

Contributor

kibanamachine commented Jun 21, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jun 22, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jun 23, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jun 24, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jun 27, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jun 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jun 29, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jun 30, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

6 similar comments

Contributor

kibanamachine commented Jul 1, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jul 4, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jul 5, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jul 6, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jul 7, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

Contributor

kibanamachine commented Jul 8, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 134114 locally

smith added auto-backport and removed backport missing labels

kibanamachine pushed a commit that referenced this pull request


          [Infrastructure UI][Rules] Fix viewInAppUrl for custom metrics for In…

5139c9c

…ventory Threshold Rule (#134114)

* [Infrastructure UI][Rules] Fix viewInAppUrl for custom metrics for Inventory Threshold Rule

* Adding test for generating link, moving custom field inside if statement

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit a020f05)

kibanamachine mentioned this pull request

[8.3] [Infrastructure UI][Rules] Fix viewInAppUrl for custom metrics for Inventory Threshold Rule (#134114) #136042

Merged

Contributor

kibanamachine commented Jul 8, 2022

💚 All backports created successfully

Status	Branch	Result
✅	8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request


          [Infrastructure UI][Rules] Fix viewInAppUrl for custom metrics for In…

84ee527

…ventory Threshold Rule (#134114) (#136042)

* [Infrastructure UI][Rules] Fix viewInAppUrl for custom metrics for Inventory Threshold Rule

* Adding test for generating link, moving custom field inside if statement

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit a020f05)

Co-authored-by: Chris Cowan <chris@chriscowan.us>

simianhacker deleted the issue-134110-fix-broken-inventory-view-in-app-url branch

April 17, 2024 15:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment