Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Move integration labels below title and normalise styling #134360

Merged
merged 2 commits into from
Jun 14, 2022
Merged

[Fleet] Move integration labels below title and normalise styling #134360

merged 2 commits into from
Jun 14, 2022

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Jun 14, 2022

Summary

Resolves #133923.

The labels were restricting the room we have for the integration title. I've taken the opportunity to consolidate our release badge components + logic into one file.

Before:
172669667-5eca1402-6a0a-47eb-b894-b55fa2b37c3b

After:

Screenshot 2022-06-14 at 15 50 22

Screenshot 2022-06-13 at 16 06 28

@hop-dev hop-dev added release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.4.0 labels Jun 14, 2022
@hop-dev hop-dev requested a review from a team as a code owner June 14, 2022 15:10
@hop-dev hop-dev self-assigned this Jun 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

nchaulet
nchaulet approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hop-dev hop-dev enabled auto-merge (squash) June 14, 2022 15:20
@hop-dev hop-dev merged commit f45e09e into elastic:main Jun 14, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 751.9KB 752.2KB +257.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@kibanamachine kibanamachine mentioned this pull request Jun 14, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Jun 14, 2022
@hop-dev
[Fleet] Move integration labels below title and normalise styling (#1…
9089534 
…34360)

* move badges below integration title

* normalise release badge styling

(cherry picked from commit f45e09e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 14, 2022
@kibanamachine @hop-dev
[Fleet] Move integration labels below title and normalise styling (#1…
e337ca9 
…34360) (#134372)

* move badges below integration title

* normalise release badge styling

(cherry picked from commit f45e09e)

Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@hop-dev hop-dev

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Integration detail] Multiple badges in header cause excessive text wrapping
5 participants
@hop-dev @elasticmachine @kibana-ci @kibanamachine @nchaulet