Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix formula generate error #134434

Merged
merged 1 commit into from
Jun 15, 2022
Merged

[Lens] Fix formula generate error #134434

merged 1 commit into from
Jun 15, 2022

Conversation

flash1293
Copy link
Contributor

Fixes #134426

by exiting formula generation early if no matching function can be found.

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens v8.3.0 v8.4.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 15, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.2MB 1.2MB +13.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review June 15, 2022 10:34
@flash1293 flash1293 requested a review from a team as a code owner June 15, 2022 10:34
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

dej611
dej611 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally 👍

@flash1293 flash1293 merged commit 39d84bc into elastic:main Jun 15, 2022
kibanamachine pushed a commit that referenced this pull request Jun 15, 2022
@flash1293
fix formula generate error (#134434)
0f4c81e 
(cherry picked from commit 39d84bc)
@kibanamachine kibanamachine mentioned this pull request Jun 15, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 15, 2022
@kibanamachine @flash1293
fix formula generate error (#134434) (#134479)
1113307 
(cherry picked from commit 39d84bc)

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Wrong transition for date field from quick function last value to formula
5 participants
@flash1293 @kibana-ci @elasticmachine @kibanamachine @dej611