Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Attach framework registry #134744

Merged
merged 16 commits into from Jun 30, 2022
Merged

[Cases] Attach framework registry #134744

merged 16 commits into from Jun 30, 2022

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Jun 20, 2022 •
edited

Summary

This PR creates an attachment registry for external references. Plugins can register their own external reference type and tell cases how they want to render their attachment type.

Screenshots

The attachments in the screenshots do not exist. They have been created for testing purposes.

Screenshot 2022-06-29 at 2 02 35 PM

Screenshot 2022-06-29 at 2 02 42 PM

Screenshot 2022-06-20 at 3 35 13 PM

Screenshot 2022-06-20 at 3 45 05 PM

Depends on: #134669

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas self-assigned this Jun 20, 2022
@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.4.0 labels Jun 20, 2022
@cnasikas cnasikas force-pushed the attach_framework_registry branch 2 times, most recently from 7e6f4cc to 95c284a Compare June 24, 2022 14:21
@cnasikas cnasikas marked this pull request as ready for review June 29, 2022 11:03
@cnasikas cnasikas requested a review from a team as a code owner June 29, 2022 11:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Jun 29, 2022
peteharverson
peteharverson approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Just added 1 comment.

x-pack/plugins/cases/public/client/attachment_framework/registry.ts Outdated Show resolved Hide resolved
@cnasikas cnasikas force-pushed the attach_framework_registry branch 2 times, most recently from ec1abfb to 0f515de Compare June 29, 2022 16:02
@cnasikas
Copy link
Member Author

buildkite test this

@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

jonathan-buttner
jonathan-buttner approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

x-pack/plugins/cases/public/client/attachment_framework/registry.ts Show resolved Hide resolved
@cnasikas cnasikas enabled auto-merge (squash) June 30, 2022 18:52
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 474 478 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 352.2KB 354.4KB +2.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
cases 23 27 +4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 113.7KB 116.0KB +2.4KB
Unknown metric groups

ESLint disabled line counts

id before after diff
cases 71 72 +1

Total ESLint disabled count

id before after diff
cases 87 88 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit 6583433 into elastic:main Jun 30, 2022
@cnasikas cnasikas deleted the attach_framework_registry branch June 30, 2022 19:58
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 30, 2022
yakhinvadim pushed a commit to yakhinvadim/kibana that referenced this pull request Jul 5, 2022
@cnasikas
[Cases] Attach framework registry (elastic#134744)
f77a647 
* Create external reference attachment registry

* Pass externalReferenceAttachmentTypeRegistry to cases client

* Better types

* Show external references user action

* Handle unregistered events

* Add e2e tests

* Fixe fixture plugin naming

* Add cases fixture plugin to tsconfig

* Fix types

* Improvements

* Fix types

* Fixes

* Fix bug

* Add unit test
@cnasikas cnasikas mentioned this pull request Jul 7, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees

@cnasikas cnasikas

Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cnasikas @elasticmachine @kibana-ci @peteharverson @jonathan-buttner @kibanamachine