Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Add API tests for filters stats endpoint #135118

Merged
merged 4 commits into from
Jun 24, 2022
Merged

[ML] Add API tests for filters stats endpoint #135118

merged 4 commits into from
Jun 24, 2022

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Jun 24, 2022 •
edited
Loading

Summary

Adds tests to check the response of the filters stats endpoint:

/api/ml/filters/_stats

Part of #133871

Checklist

@peteharverson peteharverson added review :ml Feature:Anomaly Detection ML anomaly detection release_note:skip Skip the PR/issue when compiling release notes test-api-integration v8.4.0 labels Jun 24, 2022
@peteharverson peteharverson requested a review from a team as a code owner June 24, 2022 10:42
@peteharverson peteharverson self-assigned this Jun 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this pull request Jun 24, 2022
Closed
18 tasks
pheyos
pheyos approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with just one small suggestion for this PR or a follow-up.

x-pack/test/api_integration/apis/ml/filters/get_filters_stats.ts Outdated Show resolved Hide resolved
pheyos
pheyos requested changes Jun 24, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In contrast to what I thought, It turns out that eql doesn't like different sorting of compared arrays . so we should sort the arrays before comparing them. Also a small suggestion to simplify the assertions.

x-pack/test/api_integration/apis/ml/filters/get_filters_stats.ts Outdated Show resolved Hide resolved
x-pack/test/api_integration/apis/ml/filters/get_filters_stats.ts Outdated Show resolved Hide resolved
pheyos
pheyos approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM

@qn895
Copy link
Member

qn895 commented Jun 24, 2022

LGTM 🎉

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

jgowdyelastic
jgowdyelastic approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson merged commit cf4040a into elastic:main Jun 24, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 24, 2022
@peteharverson peteharverson deleted the ml-get-filters-api-tests branch June 24, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@qn895 qn895 qn895 approved these changes

Assignees

@peteharverson peteharverson

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:skip Skip the PR/issue when compiling release notes review test-api-integration v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@peteharverson @elasticmachine @qn895 @kibana-ci @pheyos @jgowdyelastic @kibanamachine