Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Management] Fix breaking scope changes in the field format editor samples #13549

Merged
merged 1 commit into from
Aug 18, 2017
Merged

[Management] Fix breaking scope changes in the field format editor samples #13549

merged 1 commit into from
Aug 18, 2017

Conversation

chrisronline
Copy link
Contributor

Fixes #13542

@chrisronline chrisronline self-assigned this Aug 17, 2017
cjcenizal
cjcenizal approved these changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spalger
spalger approved these changes Aug 18, 2017
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though you could use $scope.$bind('id', attrs.id) on line 19 to match lines 17 & 18

@chrisronline
Copy link
Contributor Author

@spalger I don't think that will work because id isn't an angular expression, but just a string.

@chrisronline chrisronline merged commit abb54ac into elastic:master Aug 18, 2017
chrisronline added a commit that referenced this pull request Aug 18, 2017
@chrisronline
Fix breaking scope changes in the field format editor samples (#13549)
ea983c3
chrisronline added a commit that referenced this pull request Aug 18, 2017
@chrisronline
Fix breaking scope changes in the field format editor samples (#13549)
646bda2
@chrisronline
Copy link
Contributor Author

Backport:
6.x: ea983c3
6.0: 646bda2

chrisronline added a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017
@chrisronline
Fix breaking scope changes in the field format editor samples (elasti…
d5ecac1 
…c#13549)
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017
@chrisronline
Fix breaking scope changes in the field format editor samples (elasti…
ec021d6 
…c#13549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@spalger spalger spalger approved these changes

Assignees

@chrisronline chrisronline

Labels
review v6.0.0-rc1 v6.0.0 v6.1.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisronline @cjcenizal @spalger @jimgoodwin