Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Remove licence restrictions for bulk reassign and bulk unenroll #136334

Merged
merged 1 commit into from
Jul 13, 2022
Merged

[Fleet] Remove licence restrictions for bulk reassign and bulk unenroll #136334

merged 1 commit into from
Jul 13, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jul 13, 2022 •
edited
Loading

Summary

While implementing rolling upgrade we implemented we removed licence restrictions from the UI but we keep these restricitons in the Fleet APIs, that PR remove these restriction there too.

@nimarezainia it's my assumption correct here that we do not want licence restrictions for agent bulk action? (expect special case like scheduled upgrade, ...)

This bug was found by a user here https://discuss.elastic.co/t/unenrolling-multiple-agents-requires-gold-license/309518

Release note

Allow agent bulk actions without specific licence restrictions.

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 v8.3.3 labels Jul 13, 2022
@nchaulet nchaulet requested a review from a team as a code owner July 13, 2022 18:47
@nchaulet nchaulet self-assigned this Jul 13, 2022
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Jul 13, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 5a09b74 into elastic:main Jul 13, 2022
@nchaulet nchaulet deleted the fix-licence-for-bulk-actions branch July 13, 2022 23:02
kibanamachine pushed a commit that referenced this pull request Jul 13, 2022
@nchaulet
[Fleet] Remove licence restrictions for bulk reassign and bulk unenro…
963c266 
…ll (#136334)

(cherry picked from commit 5a09b74)
@kibanamachine kibanamachine mentioned this pull request Jul 13, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 14, 2022
@kibanamachine @nchaulet
[Fleet] Remove licence restrictions for bulk reassign and bulk unenro…
0ecf3f4 
…ll (#136334) (#136355)

(cherry picked from commit 5a09b74)

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@nchaulet nchaulet

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.3.3 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchaulet @elasticmachine @kibana-ci @kibanamachine @kpollich