Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Navigation from Span to Service breaks due to wrong transactionType #136569

Merged

Conversation

cauemarcondes
Copy link
Contributor

closes #135772

transaction.type.mov

Currently, if we type an unknown transaction type in the URL, the select box changes to one of the options returned by the API, but the URL keeps with the wrong value. That causes problems with components that read this value directly from the URL. I fix that by checking if the value in the URL is in the options returned by the API, if not replace it with the first option.

@cauemarcondes cauemarcondes added release_note:fix Team:APM All issues that need APM UI Team support v8.4.0 labels Jul 18, 2022
@cauemarcondes cauemarcondes requested a review from a team as a code owner July 18, 2022 20:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some small comments

@cauemarcondes cauemarcondes requested a review from a team July 22, 2022 15:59
@cauemarcondes
Copy link
Contributor Author

buildkite test this

@cauemarcondes cauemarcondes enabled auto-merge (squash) July 25, 2022 14:17
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #40 / machine learning - data visualizer field statistics in Discover when enabled with farequote index pattern displays the 'Field statistics' table content correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.0MB 3.0MB +155.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit b8b57d5 into elastic:main Jul 25, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:APM All issues that need APM UI Team support v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Navigation from Span to Service breaks due to wrong transactionType
6 participants