-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Navigation from Span to Service breaks due to wrong transactionType #136569
Merged
cauemarcondes
merged 7 commits into
elastic:main
from
cauemarcondes:apm-transaction-type-nav-bug
Jul 25, 2022
Merged
[APM] Navigation from Span to Service breaks due to wrong transactionType #136569
cauemarcondes
merged 7 commits into
elastic:main
from
cauemarcondes:apm-transaction-type-nav-bug
Jul 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cauemarcondes
added
release_note:fix
Team:APM
All issues that need APM UI Team support
v8.4.0
labels
Jul 18, 2022
Pinging @elastic/apm-ui (Team:apm) |
cauemarcondes
commented
Jul 18, 2022
x-pack/plugins/apm/public/context/apm_service/apm_service_context.tsx
Outdated
Show resolved
Hide resolved
cauemarcondes
commented
Jul 18, 2022
...details/waterfall_with_summary/waterfall_container/waterfall/flyout_top_level_properties.tsx
Outdated
Show resolved
Hide resolved
gbamparop
reviewed
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Added some small comments
x-pack/plugins/apm/public/context/apm_service/apm_service_context.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/context/apm_service/apm_service_context.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/context/apm_service/apm_service_context.tsx
Outdated
Show resolved
Hide resolved
dgieselaar
reviewed
Jul 19, 2022
dgieselaar
reviewed
Jul 20, 2022
...details/waterfall_with_summary/waterfall_container/waterfall/flyout_top_level_properties.tsx
Outdated
Show resolved
Hide resolved
buildkite test this |
dgieselaar
reviewed
Jul 25, 2022
dgieselaar
approved these changes
Jul 25, 2022
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:fix
Team:APM
All issues that need APM UI Team support
v8.4.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #135772
transaction.type.mov
Currently, if we type an unknown transaction type in the URL, the select box changes to one of the options returned by the API, but the URL keeps with the wrong value. That causes problems with components that read this value directly from the URL. I fix that by checking if the value in the URL is in the options returned by the API, if not replace it with the first option.