Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pie chart design guidelines #13661

Merged
merged 1 commit into from
Oct 2, 2017
Merged

pie chart design guidelines #13661

merged 1 commit into from
Oct 2, 2017

Conversation

ppisljar
Copy link
Member

implements #13328 for vislib pie chart

@ppisljar ppisljar added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Aug 23, 2017
thomasneirynck
thomasneirynck approved these changes Aug 25, 2017
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. This also preserves the settings of older configurations, which is a nice bonus.

as for the hover state. imo it's a separate issue, and something we should look at for all charts, as it's shared logic for all line, bar, pie charts

@ppisljar ppisljar added v6.0.0 v6.1.0 v7.0.0 review Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. labels Aug 28, 2017
@alexfrancoeur
Copy link

Looks great @ppisljar! Glad to hear we're persisting the state of previously configured pie charts as well.
@snide I think we'll need an updated icon for the Add New Viz page

screen shot 2017-08-28 at 10 22 18 am

@thomasneirynck
Copy link
Contributor

I think this is OK to merge. We'll create a separate tracker to improve the icon.

@ppisljar ppisljar merged commit dce23e6 into elastic:master Oct 2, 2017
ppisljar added a commit that referenced this pull request Oct 2, 2017
@ppisljar
pie chart design guidelines (#13661)
308c77c
ppisljar added a commit that referenced this pull request Oct 2, 2017
@ppisljar
pie chart design guidelines (#13661)
f0d59ab
@ppisljar
Copy link
Member Author

ppisljar commented Oct 2, 2017

backport:
6.x: 308c77c
6.0: f0d59ab

simianhacker pushed a commit to simianhacker/kibana that referenced this pull request Oct 2, 2017
@ppisljar @simianhacker
pie chart design guidelines (elastic#13661)
2936789
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Nov 20, 2017
@ppisljar @chrisronline
pie chart design guidelines (elastic#13661)
19952f9
chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Dec 1, 2017
@ppisljar @chrisronline
pie chart design guidelines (elastic#13661)
7d92eeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@snide snide Awaiting requested review from snide

Assignees
No one assigned
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.0.0 v6.1.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppisljar @alexfrancoeur @thomasneirynck @epixa