[Discover] Fix Discover breadcrumb losing context after page refresh or when opening in a new tab #136749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge refresh or when opening in a new tab
davismcphee
added
Feature:Discover
kertal
reviewed
Jul 21, 2022
|
Sorry, couldn't finish, to much SQL reviewing, will definitely finish tomorrow! |
kertal
approved these changes
Jul 22, 2022
There was a problem hiding this comment.
Code LGTM, tested a-la-carte and works as expected 👍 thx for this fix.
Unrelated to this, while testing I've encountered that surrounding documents don't seem to support storing the URL in the session, something no to fix in this PR, but we should take care of later on
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @davismcphee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in Surrounding documents and Single document where the breadcrumb back to Discover loses context after a page refresh or when opening in a new tab, causing the application state to reset when navigating back to Discover:
Fixes #136134.
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsAny UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listThis renders correctly on smaller devices using a responsive layout. (You can test this in your browser)For maintainers