Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] support for integration package #138224

Merged
merged 7 commits into from Aug 9, 2022

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Aug 6, 2022

Summary

This change should be tested with elastic/integrations#3965

Two updates required to support the kibana integration package:

  • added a metricset filter to the kibana instance overview query. this is required because two document types (stats and status) can be matched with the current filters but only stats has the right properties used by the UI. With metricbeat standalone this is not a problem because we only collect the stats metricset but with integrations both metricsets can be collected
  • there is a guard to only display the Rules/Actions data if the documents come from the metricbeat indice. Extended the condition to also allow metrics data streams

Testing

curl --insecure -u elastic:changeme -H 'Content-Type: application/json' \
https://localhost:9200/_security/user/kibana_system/_password -d'{"password": "changeme"}'
  • configure kibana on a different port so we don't conflict with the one started by elastic-package and ignore certificate verification
server.port: 5602

elasticsearch.username: kibana_system
elasticsearch.password: changeme
elasticsearch.ignoreVersionMismatch: true
elasticsearch.hosts: ["https://localhost:9200"]
elasticsearch.ssl.verificationMode: none
  • connect to local kibana at localhost:5602. Stack Monitoring should already have elasticsearch and kibana data, verify all kibana views are correctly populated

Note that the local kibana is not able to interact with the local package-registry when running http, this means we have to do all integration-related interaction on the kibana run by elastic-package (at :5601).
To enable ssl we can point the local kibana configuration to the certificates used by elastic-package (under ~/.elastic-package/profiles/{profile}/certs), then start the process with NODE_EXTRA_CA_CERTS=~/.elastic-package/profiles/{profile}/certs/ca-cert.pem yarn start. With that everything appears to work well except that any successful update to an agent policy from the local kibana is not picked up by the Agent, only the elastic-package updates go through. I didn't find the cause yet

@klacabane klacabane self-assigned this Aug 6, 2022
@klacabane klacabane added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.5.0 labels Aug 6, 2022
@klacabane klacabane marked this pull request as ready for review August 6, 2022 22:14
@klacabane klacabane requested a review from a team as a code owner August 6, 2022 22:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@klacabane
Copy link
Contributor Author

@elasticmachine merge upstream

@miltonhultgren miltonhultgren self-requested a review August 9, 2022 09:05
@klacabane
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Aug 9, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 479.3KB 479.3KB -14.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @klacabane

Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Tested locally and couldn't see any issues in the UI.

@klacabane klacabane merged commit b4460be into elastic:main Aug 9, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants