Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kibana] align mappings with metricbeat #3965

Merged
merged 15 commits into from
Aug 9, 2022

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Aug 6, 2022

Summary

This change should be tested with elastic/kibana#138224

Closes #3915
Closes elastic/kibana#137691

Align the kibana data streams' mappings with the metricbeat ones and add data streams to support the Rules metricsets introduced in elastic/beats#29899

Testing

When testing we have to install the elasticsearch package as well otherwise the kibana section in Stack Monitoring won't show up.

  • update the kibana fleet configuration to preinstall the elasticsearch and kibana package:
    • create a new stack profile with elastic-package profiles create stack_monitoring-kibana --from default
    • edit the fleet configuration of the profile at ~/.elastic-package/profiles/stack_monitoring-kibana/stack/kibana.config.8x.yml with this one
  • build the elasticsearch and kibana packages with elastic-package build
  • start a 8.5.0 stack within integrations repo elastic-package stack up -v -d --profile stack_monitoring-kibana --version 8.5.0-SNAPSHOT
  • verify all kibana data streams are populated (stats status cluster_actions cluster_rules node_actions node_rules)
  • inspect Stack Monitoring UI with a local kibana running [Stack Monitoring] support for integration package kibana#138224

@elasticmachine
Copy link

elasticmachine commented Aug 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-09T14:48:03.892+0000

  • Duration: 15 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@klacabane klacabane self-assigned this Aug 6, 2022
@klacabane klacabane added v8.5.0 Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Aug 6, 2022
@klacabane klacabane marked this pull request as ready for review August 6, 2022 22:14
@klacabane klacabane requested a review from a team as a code owner August 6, 2022 22:14
@elasticmachine
Copy link

elasticmachine commented Aug 6, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.874
Classes 100.0% (0/0) 💚 2.874
Methods 53.846% (14/26) 👎 -35.572
Lines 100.0% (0/0) 💚 9.367
Conditionals 100.0% (0/0) 💚

@miltonhultgren miltonhultgren self-requested a review August 9, 2022 09:04
Copy link
Contributor

@miltonhultgren miltonhultgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼 Tested locally without issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services v8.5.0
Projects
None yet
3 participants