Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] add format selector to new metric vis #139018

Merged
merged 10 commits into from Aug 20, 2022
Merged

[Lens] add format selector to new metric vis #139018

merged 10 commits into from Aug 20, 2022

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Aug 17, 2022 •
edited

Summary

This adds format-selection support to the metric visualization. Suffix and decimal-place selection are not supported since the metric visualization applies custom formatting to metric values.

Fix #139166

Screen.Recording.2022-08-18.at.9.59.17.AM.mov

Checklist

@drewdaemon drewdaemon mentioned this pull request Aug 17, 2022
Closed
15 tasks
@drewdaemon drewdaemon changed the title add partial support for format selector [Lens] add partial support for format selector Aug 17, 2022
@drewdaemon drewdaemon changed the title [Lens] add partial support for format selector [Lens] add format selector to new metric vis Aug 17, 2022
@drewdaemon drewdaemon marked this pull request as ready for review August 18, 2022 17:37
@drewdaemon drewdaemon requested a review from a team as a code owner August 18, 2022 17:37
@drewdaemon drewdaemon added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

flash1293
flash1293 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one remark, but I don't think I have to re-check after that.

Found a small unrelated bug, going to open a separate issue for this.

x-pack/plugins/lens/public/visualizations/metric/visualization.tsx Outdated Show resolved Hide resolved
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@drewdaemon
Copy link
Contributor Author

I added logic to ignore the suffix formatter at the expression level. It is a little funny that the suffix sticks around in the suggestions, but probably not a big deal, right?
Screen Shot 2022-08-19 at 2 13 38 PM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionMetricVis 71.6KB 71.7KB +79.0B
lens 1.2MB 1.2MB +285.0B
total +364.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293
Copy link
Contributor

flash1293 commented Aug 20, 2022 •
edited

That’s fine imho

@drewdaemon drewdaemon merged commit 5752feb into elastic:main Aug 20, 2022
@kibanamachine kibanamachine added v8.5.0 backport:skip This commit does not require backporting labels Aug 20, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@drewdaemon @Mpdreamz
[Lens] add format selector to new metric vis (elastic#139018)
47d5624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Metric vis fails on transition if suffix is set
5 participants
@drewdaemon @elasticmachine @kibana-ci @flash1293 @kibanamachine