Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] clear metric visualization state #139154

Merged
merged 3 commits into from Aug 19, 2022
Merged

[Lens] clear metric visualization state #139154

merged 3 commits into from Aug 19, 2022

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Aug 18, 2022 •
edited

Summary

Visualization state is now properly cleared when

  • a dimension is removed whose editor contained the extra settings
  • the layer is cleared

Also, adding missing validation for the max accessor.

Checklist

@drewdaemon drewdaemon mentioned this pull request Aug 18, 2022
Closed
15 tasks
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionMetricVis 71.6KB 71.6KB -38.0B
lens 1.2MB 1.2MB -33.0B
total -71.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionMetricVis 10.0KB 10.0KB +44.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon marked this pull request as ready for review August 19, 2022 01:19
@drewdaemon drewdaemon requested a review from a team as a code owner August 19, 2022 01:19
@drewdaemon drewdaemon added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

flash1293
flash1293 approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested around and everything works fine, LGTM

@drewdaemon drewdaemon merged commit 0488b46 into elastic:main Aug 19, 2022
@kibanamachine kibanamachine added v8.5.0 backport:skip This commit does not require backporting labels Aug 19, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@drewdaemon @Mpdreamz
[Lens] clear metric visualization state (elastic#139154)
fbbf2f8 
* clean up state when dimensions removed and layer cleared

* validate max accessor

* simplify some logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drewdaemon @kibana-ci @elasticmachine @flash1293 @kibanamachine