[Files] Added usage counters for delete, unshare and download #140091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloleysens
added
release_note:skip
jloleysens
force-pushed
the
files-telemetry-part-ii-KS-2835
branch
from
419b44e
to
07a807f
Compare
jloleysens
force-pushed
the
files-telemetry-part-ii-KS-2835
branch
from
393bfd1
to
abc5031
Compare
jloleysens
force-pushed
the
files-telemetry-part-ii-KS-2835
branch
from
eb3aed2
to
6ae6c5c
Compare
|
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
tsullivan
requested changes
Sep 14, 2022
| export function getCounters(prefix: string) { | ||
| return { | ||
| DELETE: `${prefix}_delete`, | ||
| DELETE_ERROR: `${prefix}_delete_error`, |
There was a problem hiding this comment.
Would it be possible to get more context to the error counter names, such as an error code? I think we could get more value by using event names for errors in the form of: eventType:error:errorCode.
Example: csv_download:error:403
There was a problem hiding this comment.
That's a really good idea @tsullivan!
I've mapped out some known errors that I think would be of interest. The download case is a little bit hard because the error space is not very well mapped out. Let me know what you think!
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 21, 2022
* main: [SearchBar] Allow show refresh button as an icon (elastic#141088) [Files] Added usage counters for delete, unshare and download (elastic#140091) Fix removing a single field formatter (elastic#141078) [APM] Move service metric config to kibana advanced settings (elastic#141147) Synthetics project update improvements (elastic#140990)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To better track usage, this PR introduces use of usage counters of a select set of actions to enrich telemetry.
Continuation from: #140079