Fix removing a single field formatter #141078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosant
added
release_note:fix
Feature:Data Views
|
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
mattkime
approved these changes
Sep 21, 2022
|
Worth backporting to 8.4 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 21, 2022
(cherry picked from commit f44f1d1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 21, 2022
* main: [SearchBar] Allow show refresh button as an icon (elastic#141088) [Files] Added usage counters for delete, unshare and download (elastic#140091) Fix removing a single field formatter (elastic#141078) [APM] Move service metric config to kibana advanced settings (elastic#141147) Synthetics project update improvements (elastic#140990)
kibanamachine
added a commit
that referenced
this pull request
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #134873
When updating a data view saved object, make sure we send an empty field format object instead of an undefined one when there are no field formats.
I think the fix makes sense, especially considering that this is how we treat
sourceFiltersandruntimeFieldMapI saw this attempt to fix it #134874, but it looks like it is a more risky change