Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens][Agg based Goal] Navigate to Lens Goal functional tests. #143527

Merged
merged 1 commit into from
Oct 19, 2022
Merged

[Lens][Agg based Goal] Navigate to Lens Goal functional tests. #143527

merged 1 commit into from
Oct 19, 2022

Conversation

Kuznietsov
Copy link
Contributor

@Kuznietsov Kuznietsov commented Oct 18, 2022 •
edited
Loading

Summary

Completes part of #138236

  • Static value (reference lines/formula/static value column for different visualizations)
  • Count
  • Metric with source field
  • Sibling pipeline
  • Parent pipeline
  • Not supported aggregations
  • Invalid aggregations
  • Color rules

Flaky tests check: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1445

@Kuznietsov Kuznietsov added the WIP Work in progress label Oct 18, 2022
@Kuznietsov Kuznietsov self-assigned this Oct 18, 2022
@Kuznietsov Kuznietsov added test_xpack_functional Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. backport:skip This commit does not require backporting v8.6.0 loe:small Small Level of Effort labels Oct 18, 2022
@Kuznietsov Kuznietsov mentioned this pull request Oct 18, 2022
Closed
28 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@Kuznietsov Kuznietsov marked this pull request as ready for review October 19, 2022 07:38
@Kuznietsov Kuznietsov requested a review from a team as a code owner October 19, 2022 07:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@stratoula
Copy link
Contributor

@Kunzetsov can you also add a test with a split group to test that a breakdown dimension is created?

stratoula
stratoula approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that the last scenario is using a split dimension so the case I mention above is tested. LGTM

@Kuznietsov Kuznietsov removed the WIP Work in progress label Oct 19, 2022
@Kuznietsov Kuznietsov merged commit b232f35 into elastic:main Oct 19, 2022
kc13greiner pushed a commit to kc13greiner/kibana that referenced this pull request Oct 19, 2022
@Kuznietsov @kc13greiner
[Lens][Agg based Goal] Navigate to Lens Goal functional tests. (elast…
0695e4e 
…ic#143527)
guskovaue pushed a commit to guskovaue/kibana that referenced this pull request Oct 22, 2022
@Kuznietsov @guskovaue
[Lens][Agg based Goal] Navigate to Lens Goal functional tests. (elast…
0bf2aae 
…ic#143527)
e40pud pushed a commit to e40pud/kibana that referenced this pull request Oct 24, 2022
@Kuznietsov @e40pud
[Lens][Agg based Goal] Navigate to Lens Goal functional tests. (elast…
a42b185 
…ic#143527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

Assignees

@Kuznietsov Kuznietsov

Labels
backport:skip This commit does not require backporting Feature:Lens Feature:Vis Editor Visualization editor issues impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test_xpack_functional v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kuznietsov @kibana-ci @elasticmachine @stratoula