[Files] Make files namespace agnostic #144019
Conversation
jloleysens
added
auto-backport
|
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
* main: [Fleet] Add the @Custom pipeline only to the main datastream ingest pipelines (elastic#144150) Upgrade @elastic/makelogs from v6.0.0 to v6.1.1 (elastic#144231) [Files] move to src (elastic#144044) [Synthetics UI] Add pagination and date filtering to test runs table (elastic#144029)
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
As said in comment, I think we should be fine with this change, but I'd like @rudolf to double check that
| @@ -48,7 +48,7 @@ const properties: Properties = { | |||
| export const fileObjectType: SavedObjectsType<FileMetadata> = { | |||
| name: FILE_SO_TYPE, | |||
| hidden: true, | |||
| namespaceType: 'multiple-isolated', | |||
| namespaceType: 'agnostic', | |||
There was a problem hiding this comment.
So, we've been trying with @rudolf to find scenarios where this change could be dangerous, but I couldn't find any. So I think this may be fine.
We may want to add a migration to get rid of / clear the namespaces attribute from the existing documents though?
There was a problem hiding this comment.
Based on our telemetry I can't see any clusters with files saved objects, so perhaps it's not generally available yet?
Changing existing saved objects from multiple-isolated to agnostic is not something we've ever tried to do or that's tested. So if we expect that there could be deployments with existing files saved objects we should thoroughly test how it behaves.
There was a problem hiding this comment.
Right now there are no existing files integrations using saved objects in our code. In order to use files saved objects there must be a call to registerFileKind. Currently this is only in our files_example plugin.
* main: (43 commits) [Synthetics] Step details page screenshot (elastic#143452) [Lens] Datatable expression types improvement. (elastic#144173) [packages/kbn-journeys] start apm after browser start and stop after browser is closed (elastic#144267) [Files] Make files namespace agnostic (elastic#144019) Implement base browser-side logging system (elastic#144107) Correct wrong multiplier for byte conversion (elastic#143751) [Monaco] Add JSON syntax support to the Monaco editor (elastic#143739) CCS Smoke Test for Remote Clusters and Index Management (elastic#142423) [api-docs] Daily api_docs build (elastic#144294) chore(NA): include progress on Bazel tasks (elastic#144275) [RAM] Allow users to see event logs from all spaces they have access to (elastic#140449) [APM] Show recommended minimum size when going below 5 minutes (elastic#144170) [typecheck] delete temporary target_types dirs in packages (elastic#144271) [Security Solution][Endpoint] adds new alert loading utility and un-skip FTR test for endpoint (elastic#144133) [performance/journeys] revert data_stress_test_lens.ts journey step (elastic#144261) [TIP] Use search strategies in Threat Intelligence (elastic#143267) Optimize react-query dependencies (elastic#144206) [babel/node] invalidate cache when synth pkg map is updated (elastic#144258) [APM] AWS lambda estimated cost (elastic#143986) [Maps] layer group wizard (elastic#144129) ...
Summary
Per the title