Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Files] move to src #144044

Merged
merged 24 commits into from
Oct 31, 2022
Merged

[Files] move to src #144044

merged 24 commits into from
Oct 31, 2022

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Oct 26, 2022 •
edited
Loading

Moves the files and files_example plugins to src.

Notes

  • Most changes should be license headers

@github-actions
Copy link

Documentation preview:

@jloleysens jloleysens marked this pull request as ready for review October 27, 2022 13:55
@jloleysens jloleysens requested review from a team as code owners October 27, 2022 13:55
@jloleysens jloleysens enabled auto-merge (squash) October 27, 2022 20:51
@jloleysens jloleysens added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated: Automatically backport this PR after it's merged Team:AppServicesUx feature:Files v8.6.0 labels Oct 27, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@jloleysens
Merge branch 'main' into files-move-to-src
1b2d913 
* main: (24 commits)
  [Files] Add file upload to file picker (elastic#143969)
  [Security solution] Guided onboarding, alerts & cases (elastic#143598)
  [APM] Critical path for a single trace (elastic#143735)
  skip failing test suite (elastic#143933)
  [Fleet] Update GH Projects automation (elastic#144123)
  [APM] Performance fix for 'cardinality' telemetry task (elastic#144061)
  [Enterprise Search] Attach ML Inference Pipeline - Pipeline re-use (elastic#143979)
  [8.5][DOCS] Add support for differential logs (elastic#143242)
  Bump nwsapi from v2.2.0 to v2.2.2 (elastic#144001)
  [APM] Add waterfall to dependency operations (elastic#143257)
  [Shared UX] Add deprecation message to kibana react Markdown (elastic#143766)
  [Security Solution][Endpoint] Adds RBAC API checks for Blocklist (elastic#144047)
  Improve `needs-team` auto labeling regex (elastic#143787)
  [Reporting/CSV Export] _id field can not be formatted (elastic#143807)
  Adds SavedObjectsWarning to analytics results pages. (elastic#144109)
  Bump chromedriver to 107 (elastic#144073)
  Update cypress (elastic#143755)
  [Maps] nest security layers in layer group (elastic#144055)
  [Lens][Agg based Heatmap] Navigate to Lens Agg based Heatmap. (elastic#143820)
  Added support of saved search (elastic#144095)
  ...
afharo
afharo approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry schema LGTM

@jloleysens
Merge branch 'main' into files-move-to-src
866c302 
* main: (41 commits)
  [api-docs] Daily api_docs build (elastic#144212)
  Add readonly view to role management (elastic#143893)
  [api-docs] Daily api_docs build (elastic#144208)
  [APM] Adds button group to navigate to "All services" (elastic#142911)
  Update react-query to ^4.12.0 (main) (elastic#139986)
  [APM] Support specific fields when creating service groups (elastic#142201) (elastic#143881)
  [api-docs] Daily api_docs build (elastic#144203)
  [ts] add stub index.d.ts in @kbn/ui-shared-deps-npm
  [Synthetics] Fix failing Synthetics Integration test (elastic#144175)
  chore(NA): remove @types/pkg link creation when generating a new package (elastic#144200)
  [Osquery] Update schema to v5.5.1 (elastic#144090)
  [ci] remove github-checks-reporter (elastic#144193)
  [8.6][ML Inference] Verify pipeline usage before deletion (elastic#144053)
  [ts] ts refs cache was removed, remove capture task
  Added Rollups CCS Test (elastic#144074)
  [auto] migrate existing plugin/package configs
  [ts] stop building @types packages in bootstrap
  skip failing test suite (elastic#142762)
  skip failing test suite (elastic#144186)
  [Fleet] Show Add Fleet Server instead of add agent when adding agent from agent policy (elastic#144105)
  ...
Dosant
Dosant approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

paul-tavares
paul-tavares approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - from Security Solution Endpoint Onboarding and Lifecycle management team

👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
files 27.2KB 26.5KB -616.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
files 19.5KB 19.3KB -244.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 443 +4
total +17

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 520 +4
total +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 1ed2ec8 into elastic:main Oct 31, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 31, 2022
@jloleysens jloleysens deleted the files-move-to-src branch October 31, 2022 13:50
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 31, 2022
@jloleysens
Merge branch 'main' into files-record-created-by
0c910e7 
* main:
  Upgrade @elastic/makelogs from v6.0.0 to v6.1.1 (elastic#144231)
  [Files] move to src (elastic#144044)
  [Synthetics UI] Add pagination and date filtering to test runs table (elastic#144029)
  Update time range when opening timeline from Entity Analytics page (elastic#144024)
  [Security Solution] Added guided onboarding for the rules area (elastic#144016)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 31, 2022
@jloleysens
Merge branch 'main' into files-make-files-namespace-agnostic
5aa9510 
* main:
  [Fleet] Add the @Custom pipeline only to the main datastream ingest pipelines (elastic#144150)
  Upgrade @elastic/makelogs from v6.0.0 to v6.1.1 (elastic#144231)
  [Files] move to src (elastic#144044)
  [Synthetics UI] Add pagination and date filtering to test runs table (elastic#144029)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@mdefazio mdefazio mdefazio approved these changes

@afharo afharo afharo approved these changes

@Dosant Dosant Dosant approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged backport:skip This commit does not require backporting feature:Files release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jloleysens @elasticmachine @kibana-ci @jbudz @mdefazio @afharo @Dosant @paul-tavares @kibanamachine